Problem/Motivation

We are using this module in our thunder distribution. When we are executing our JS tests, the config checker complains that there is a missing key in the multi_step_display schema.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#21 interdiff.txt950 bytesslashrsm
#21 2812901_21.patch540 bytesslashrsm
#20 2812901-20.patch627 bytessamuel.mortenson
#15 interdiff.txt1.18 KBslashrsm
#15 2812901_15.patch4.77 KBslashrsm
#12 interdiff.txt837 bytesslashrsm
#12 2812901_12.patch4.04 KBslashrsm
#9 interdiff.txt1.71 KBslashrsm
#9 2812901_9.patch3.22 KBslashrsm
#8 adjust_schema_file-2812901-8.patch3.82 KBchr.fritsch
#5 incomplete_schema_for-2812901-5.patch3.21 KBchr.fritsch
#4 incomplete_schema_for-2812901-4.patch2.54 KBchr.fritsch
#2 incomplete_schema_for-2812901-2.patch532 byteschr.fritsch

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new incomplete_schema_for-2812901-2.patch532 bytes

Here is a patch. I'am currently not sure if this is the proper way to fix ist. We are using rendered_entity as display in the multi_step selection_display

slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work
Issue tags: +D8Media 
+++ b/config/schema/entity_browser.schema.yml
@@ -139,6 +139,10 @@ entity_browser.browser.selection_display.multi_step_display:
+      mapping:
+        view_mode:
+          type: string
+          label: 'View mode'

Arbitrary plugin can be used here and each plugin can have arbitrary config.

I think that we need to create schema for each plugin separately and relate to it from here.

We have the same problem in field widget schema definitions. Should fix that too.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new incomplete_schema_for-2812901-4.patch2.54 KB

Lets give this a try.

I've added a rendered_entity section to multi_step and field_widget_display_settings. For label is no need, because its empty.

Additionally i removed field_widget_display and field_widget_display_settings from the file browser schema because its unset in FileBrowserWidget::defaultSettings()

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Title: Incomplete schema for multi_step_display » Adjust schema file
StatusFileSize
new incomplete_schema_for-2812901-5.patch3.21 KB

I've removed some schema properties for display.standalone and display.iframe, because they are not used in the displays.

Status: Needs review » Needs work

The last submitted patch, 5: incomplete_schema_for-2812901-5.patch, failed testing.

The last submitted patch, 5: incomplete_schema_for-2812901-5.patch, failed testing.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new adjust_schema_file-2812901-8.patch3.82 KB

testStandaloneDisplay used a wrong configuration. Fixed that

slashrsm’s picture

slashrsm commented
StatusFileSize
new 2812901_9.patch3.22 KB
new interdiff.txt1.71 KB

Multi step display re-uses field widget display plugins. I propose that we do the same with config schema.

Status: Needs review » Needs work

The last submitted patch, 9: 2812901_9.patch, failed testing.

The last submitted patch, 9: 2812901_9.patch, failed testing.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 2812901_12.patch4.04 KB
new interdiff.txt837 bytes

Another proof why having incomplete schema is a really bad idea. I committed this few moments ago...

Status: Needs review » Needs work

The last submitted patch, 12: 2812901_12.patch, failed testing.

The last submitted patch, 12: 2812901_12.patch, failed testing.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 2812901_15.patch4.77 KB
new interdiff.txt1.18 KB

Hopefully I fixed all of them.

slashrsm’s picture

slashrsm commented

Finally green. @chr.fritsch I'll wait for your feedback before committing.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Looks fine for me. Our thunder tests are working with that changes, too.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Committed. Thanks!

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Fixed » Needs review
StatusFileSize
new 2812901-20.patch627 bytes

Looks like the ImageThumbnail plugin was missed from the schema changes, which broke File Browser installs. Here's a quick follow-up patch that addresses that.

slashrsm’s picture

slashrsm commented
StatusFileSize
new 2812901_21.patch540 bytes
new interdiff.txt950 bytes

This partly went in in #2809659: Make field widget display plugins implement ConfigurablePluginInterface, but it is far from perfect.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.