Follow-up to #2810533-12: Advanced panels 8.x-3.x based on the work of Lightning profile

CommentFileSizeAuthor
#5 interdiff-2810643-2-5.txt86.49 KBminakshiPh
#5 fix-drupal-coding-std-2810643-5.patch165.68 KBminakshiPh
#2 2810643-2.patch93.72 KBnaveenvalecha

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Active » Needs work
StatusFileSize
new 2810643-2.patch93.72 KB

Here's the starting patch which fixes the coding standards.
phpcbf --standard=Drupal panels/
It still needs work for adding the comments at few places.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: +Novice, +Coding standards
minakshiPh’s picture

minakshiPh commented
Assigned: Unassigned » minakshiPh
minakshiPh’s picture

minakshiPh commented
Assigned: minakshiPh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new fix-drupal-coding-std-2810643-5.patch165.68 KB
new interdiff-2810643-2-5.txt86.49 KB

Added the patch with modifications as mentioned in #2.

Kindly review.
Thanks!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2809841: Plan for Panels 8.x-3.0-beta6

We should get this in sooner so that it doesn't have to be constantly rerolled.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Closed (outdated)

I ran a code cleanup script. This is no longer needed.