Problem/Motivation

There is no test coverage in this module.
As #797826: SMTP in core was created in the Ideas queue, I would say this would be a blocker for that.
As this module is quite relevant, I guess we better ensure that we don't break it :)

Proposed resolution

Write tests, at least for the most basic functionality. Then we can improve later.

Remaining tasks

Define main tests that are needed. Create a patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

penyaskito created an issue. See original summary.

  • wundo committed 1109eae on 8.x-1.x 
    Issue #2808081 by wundo: Adding test to SMTPConfigForm
  • wundo committed 1f11e61 on 8.x-1.x
    Issue #2808081 by wundo: Move PHPMailerException to outside the Plugin...
  • wundo committed 220f818 on 8.x-1.x
    Issue #2808081 by wundo: Fixes FormInterface implementation
  • wundo committed 24f7f6b on 8.x-1.x
    Issue #2808081 by wundo: Linting SMTPMailSystem

  • wundo committed ece1866 on 8.x-1.x 
    Issue #2808081 by wundo: Fixes typo
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

There is test coverage now, but it is very broken.

wundo’s picture

wundo commented

@borisson_ any patch you can provide is more than welcome.

wundo’s picture

wundo commented

  • wundo committed 84f789c on 8.x-1.x 
    Issue #2808081 by wundo: Fixes tests in older PHP versions
bluegeek9’s picture

bluegeek9 commented
Status: Active » Closed (outdated)

There have been commits made under this issue. There has not been activity for 7 years. I think the issue is outdated by now.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.