File Browser module adds CSS which improves the appearance of the entity browser, but this CSS isn't specific to what File Browser is doing.

It could therefore be added to this module, where it would be of more benefit.

So far, the only thing I can see is the 0 margins for the container, but this makes a big difference to the amount of space a view has, as can be seen in this screenshot -- plain entity browser on the left, File Browser's browser on the right.

Before:

After:

CommentFileSizeAuthor
#6 Izbor_069.png14.26 KBslashrsm
#6 Izbor_070.png14.67 KBslashrsm
#4 interdiff-2808017-2-4.txt1.05 KBsamuel.mortenson
#4 2808017-4.patch2.26 KBsamuel.mortenson
#2 2808017-2.entity_browser.move-css-from-file-browser.patch1.14 KBjoachim
entity browser - file browser spacing comparison.png46.22 KBjoachim

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2808017-2.entity_browser.move-css-from-file-browser.patch1.14 KB

Here's a patch.

slashrsm’s picture

slashrsm commented
Issue tags: +D8Media

Thank you for working on this patch.

I think we should leave at least some margin to prevent visual interference with the iframe border. Of (even better) if we could get rid of it.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
StatusFileSize
new 2808017-4.patch2.26 KB
new interdiff-2808017-2-4.txt1.05 KB

File Browser includes another CSS file just to remove the border around iFrames :-)

I've updated the patch with a similar file, for all Entity Browsers using the iFrame Display.

slashrsm’s picture

slashrsm commented
Issue summary: View changes
Status: Needs review » Fixed
StatusFileSize
new Izbor_070.png14.67 KB
new Izbor_069.png14.26 KB

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.