If terms of use text is lengthy, the form will be too long. So there should be option to chose whether it is collapsed or not.

CommentFileSizeAuthor
#4 terms_of_use_fieldset_collapsed_2808007-4.patch2.82 KBprashant.c
#4 terms-of-user-collapsed.png40.26 KBprashant.c
#4 terms-of-use-collapsed-setting.png46.17 KBprashant.c
#2 terms_of_use_fieldset_collapsed_2808007-#1.patch3.32 KBkrishnarp

Comments

krishnarp created an issue. See original summary.

krishnarp’s picture

krishnarp commented
Status: Active » Needs review
StatusFileSize
new terms_of_use_fieldset_collapsed_2808007-#1.patch3.32 KB

I have added an option in admin form to chose whether it is to be shown collapsed or not. Also cleared all coding standard issues. Attaching the patch. Kindly check.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs work » Needs review
StatusFileSize
new terms-of-use-collapsed-setting.png46.17 KB
new terms-of-user-collapsed.png40.26 KB
new terms_of_use_fieldset_collapsed_2808007-4.patch2.82 KB

Re-rolled the patch and re-factored the code also.
PFA for patch and settings form.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Issue tags: -Needs reroll

Removing the tag as the rerolled patch is in.

ivnish’s picture

ivnish
he/him
commented

Thanks!

  • ivnish committed 206f1b4 on 8.x-2.x authored by Prashant.c 
    Issue #2808007 by Prashant.c, krishnarp, ivnish, heykarthikwithu, AjitS...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.