Comments

kevinquillen created an issue. See original summary.

miro_dietiker’s picture

Zero test coverage = unknown terrain.
I just discovered the module for the first time today.
;-D

Happy to hear back about where we need to consider supporting it and where things break.. and what test coverage of real life use cases makes sense!

miro_dietiker’s picture

Issue tags: +Needs tests

Quickly tested it a bit...
I'm confused about how implicitly content is unpublished if you uncheck the "make it published" button for a state...

There is some risk of breaking things in the flag "Default revision".
Without content moderation, every new revision added was getting default revision...
While dealing with default revision and updating it in sync with the host was recent subject, i'm not sure what we decided for.
It's possibly that we always force an update and don't do this conditionally, so pointers could be wrong.

At least, we should add tests that check non-default-revision behavior and make sure things are in sync.

Other than that i doubt there is a problem.

miro_dietiker’s picture

Tested to add some own states and transitions with content moderation, but was unable to make them show up.
Also the whole UI changes of it contain some UX problems so that's sometimes not clear to the user if it just updates a draft or the node itself.

Interestingly, if i use the "Set as default revision" button in the revision tab, it just creates a new revision without being the default.

Anyway, not related to Paragraphs itself, lots of stuff to work on - mostly core issues. Hope things are clear enough to make Paragraphs work right with it...

kevinquillen’s picture

It works with core revisions though, correct?

jmuzz’s picture

It is tested and should work as long as the content moderation module is disabled.

The content moderation module is now an experimental core module though, so I don't know if we can keep saying it works with "core revisions."

miro_dietiker’s picture

It works with revisions as long as you save forward.
If you revert to a previous revision, the host points back to the old paragraph revision.
If you then update that revision (as unchecking "new revision" checkbox) then the old revision is updated.
Also deleting a revision is not really supported..

But yeah, regular creation of new revisions is what we do in production since a while. Including multilngual. And we already have polished out a huge deal of edge case issues identified...

miro_dietiker’s picture

Title: Content Moderation in 8.2.x+ » META Support Content Moderation in 8.2.x+
Category: Support request » Feature request

META'izing and making it a feature request.
Also postponed some related issues for this general Content Moderation problem.

First, we want to know where Core is heading and how to solve the related problems before we jump into implementing related features.

damienmckenna’s picture

Agreed on tests being the best starting point, maybe start off with cloning the existing tests and enabling a Content Moderation workflow, see what pieces need to be filled in?

miro_dietiker’s picture

Also stumbled upon the ERR issue about improving default revision handling where we need to investigate forward revision cases as well.

miro_dietiker’s picture

miro_dietiker’s picture

Priority: Normal » Critical

Promoting according to the roadmap.

miro_dietiker’s picture

Issue summary: View changes

Adding references to all the children and prioritisation.

jasonawant’s picture

This issue may need an update, I'm still trying to make sense of the current state.

See https://www.drupal.org/project/paragraphs/issues/2951436#comment-12610381

1. Update paragraphs to the dev version
2. Update Entity referernce revisions to the dev version
3. Apply the latest patch from this core issue #2960253: [meta] Allow Paragraphs widget/field and similar use cases to to be considered translatable
4. Apply the latest patch from the issue you are currently reading
5. Apply the latest patch from thie entity_reference_revisions issue #2961399: Support parallel translation forward revisions on untranslatable fields

From that, #2960253: [meta] Allow Paragraphs widget/field and similar use cases to to be considered translatable has been split into three issues

damienmckenna’s picture

As an update, it seems like all of the referenced core issues have been resolved. For single language sites, should this be working correctly now?

miro_dietiker’s picture

The key child issue has been committed. However, the implementation changed direction to find an acceptable minimum that works with current core limitations.

Paragraphs HEAD now depends to the latest ERR 1.6 release from today, supporting multilingual content moderation.
Fatal errors are gone, multiple forward draft revisions are supported, data loss should not happen anymore.
We have additional 34 followers here, so please help testing, a release is near.

Due to core limitations however, it is not fully satisfying:
The published revision of the source language is defining the structure of a host entity. Forward draft revisions of translations can currently not translate a Paragraph that was added by a forward draft revision in the source (language) until that was published.

We need to figure out how we can pass in the structure of the most recent source (language) revision into the translation drafts to allow translating new information. Publishing the source first before being able to translate a Paragraph is simply not possible for many application. You can technically not release anymore information including translations at a specific point in time.

berdir’s picture

We created #3004099: Allow to translate paragraphs from pending revisions for that, but nothing to see yet. See also #2833049-14: ContentEntityBase::hasTranslationChanges will compare a forward revision with the default one instead of the newest forward revision for some more thoughts and one of the related core issues, as mentioned there, we need to create a new one and discuss the approach to allow this.

maximpodorov’s picture

Probably the proper solution is to support asymmetric translations only. The complexity of 3-dimentional (id, revision, language) data is too high.

miro_dietiker’s picture

Issue summary: View changes
xmacinfo’s picture

What is the current situation in regards with Drupal 8.9.x and 9.1.x? Any progress in making Content Moderation compatible with Paragraphs?

jcisio’s picture

Title: META Support Content Moderation in 8.2.x+ » META Support Content Moderation module
Assigned: kevinquillen » Unassigned

I don't link leaving "in 8.2.x+" make it clearer.