Rename Outside-in module to "Settings Tray" for real

Let's make this one of the last things we do, so as not to destabilize other work going on.

De-sprinty-tagging per #2.

Does this need an extra "release blocker" tag so nobody forgets about it?

Lets do that yes, thanks Damien.

hmm did we miss this?

@yoroy no I thin the idea was to do this as the last thing before the module is marked as stable.

I don't know what others think. The actually patch will be very simple to make but keeping it up to date if other patches are being worked on would be time consuming.

@saurabh-chugh I really think we should postpone this and done this at the end.

Keeping this patch update to while other work on this module is going to be a nightmare.

But that being said if you want to work on it knowing that I welcome you too.

If you want to work on something else related to this module there are bunch of other issues that need review or work. If want help finding another issue feel to contact me via my drupal.org contact form or tedbow on irc or drupal slack.

Thanks.

Renamed the Outside-in module to "Settings Tray"

@saurabh-chugh thanks for the patch. setting to "Needs Review" so the test run.

@saurabh-chugh just unassigning because it has been a couple of week. Thanks for starting it.

I am going to postpone because I think it will be easier to do once the module is closer to stable. Hopefully soon.

But of course if @saurabh-chugh or anyone wants to provide a patch that would also be welcome. I just think it will be hard to keep the patch up-to-date with other changes because it will touch almost every file.

Ok trying this again. But I think should not be committed before #2782891: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling because it is RTBC and this would make it need a reroll.

So including a patch for testing including this patch #2782891-81: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling

It would great to also commit this issue first #2826722: Add a 'fence' around settings tray with aggressive CSS reset. but not sure if that is going to happen.

Settings to "Needs Review" but will probably postpone for now if tests pass.

Tests pass! Marking postponed per #17.

Unpostoning because #2782891: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling just landed. 🎉

Is this completely unblocked? If so, this needs a reroll.

The release notes at https://www.drupal.org/project/drupal/releases/8.4.0-beta1 only mention two other issues besides this one blocking beta, both of which are in. So, yep! I think we just need a patch here and are good to go! :D

Can this still happen during 8.4's beta?

(Note that those two others are fixed already: #2902361: [regression] In Settings Tray when the form is longer than the page body it is tricky to scroll to the very bottom. + #2782891: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling.)

Although #2904134: Settings Tray uses the off-canvas dialog type, but "off_canvas" is not an accurate form plugin name, "settings_tray" is would probably be a new beta blocker, uncovered by #2782891: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling.

Well, it can definitely be committed to 8.5.x. Not sure indeed whether we could backport it at this point, but step 1 is getting it in 8.5.x. :)

This can happen at any time before 8.4.0 since Settings Tray is still alpha, and Settings Tray can also be marked beta at any time. Thanks!

Making it clear that this is postponed on the follow-up indicated at #2904134-10: Settings Tray uses the off-canvas dialog type, but "off_canvas" is not an accurate form plugin name, "settings_tray" is.

And that's done now!

Removing "Release blocker" tag; that's not a thing we track.

There's a patch here, so needs review.

Looking good! @cilefen thanks for getting this going again.

Just few cases of "outside" in the code base that need to be removed.

1. +++ b/core/modules/settings_tray/js/settings_tray.es6.js
   @@ -224,7 +224,7 @@
   -          instance.options.data.dialogOptions.outsideInActiveEditableId = $(instance.element).parents('.outside-in-editable').attr('id');
   +          instance.options.data.dialogOptions.outsideInActiveEditableId = $(instance.element).parents('.settings-tray-editable').attr('id');
   

   outsideInActiveEditableIdshould be settingTrayActiveEditableId

2. +++ b/core/modules/settings_tray/js/settings_tray.es6.js
   @@ -234,16 +234,16 @@
            const $activeElement = $(`#${settings.outsideInActiveEditableId}`);
   

   settingTrayActiveEditableId

3. Also in settings_tray.es6.js Drupal.behaviors.toggleEditMode still has the comment

   /**
      * Toggle the js-outside-edit-mode class on items that we want to disable while in edit mode.
      *
      * @type {Drupal~behavior}
      *
      * @prop {Drupal~behaviorAttach} attach
      *   Toggle the js-outside-edit-mode class.
      */
   

   which should have js-settings-tray-edit-mode instead of js-outside-edit-mode

#38 had strange unrelated test failures but the patch doesn't seem to have any unrelated changes. Retesting

Ok #38 tests passing. Search module for "outside" and there were only few remaining instances such as

Position the dialog-off-canvas tray container outside the right of the viewport.

which are not dealing with the machine name.

Everything else looks good!

Let's get this in while it's hot!

Committed and pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

Btw, I'm not sure why that 8.4.x push isn't showing up, but it did make it across the line: http://cgit.drupalcode.org/drupal/commit/core/modules?id=57e7afbda3ba2db...

@webchick can we then now please also rename the component here on d.o from outside_in.module to settings_tray.module?

(: cheers. nice to see it finally have a real name.

Yep. Unfortunately though, if I do that through the UI, every issue currently assigned to outside_in.module needs to be manually re-assigned to settings_tray.module. :\ The DA might be able to help with an upgrade path. And/or I'll just try and find a couple of volunteers to help with this later when I have a free hour.

Oh, I thought you'd be able to just rename the existing component. But apparently not. Should I ask drumm in #drupal-infrastructure for this? Or perhaps @tedbow was right all along, we need to open a "webmasters" issue?

Changing to new settings_tray.module component. @drpal thanks for script help! :)