Fix h5p module js compression issues

Perhaps I could manually set $_GET['AdvAgg']=1 if $node->type=='h5p_content'. But what hook would I use to make this assignment?

Works! awesome, Thanks! That could a feature request for AdvAgg. Add the ability to enable or disable by content type and or path, similar to Block visibility. AdvAgg is awsome, however, it does not play well with certain modules and so this could increase the use base if it was easier to disable AdvAgg for problematic situations.

Changing to feature request.

I needed to extend this to also turn of AdvAgg for H5P quiz questions...

function custom_module_page_alter() {
/*** Get the current active node ***/
$node = menu_get_object();
if (!empty($node->type) && ($node->type == 'h5p_content' || ($node->type == 'quiz' && arg(2)=='take'))) {
	$GLOBALS['conf']['advagg_js_compressor'] = 0;
}
}

using jsmin, the compiled C version, though the php jsmin also fails the same way.

I am using FF, but don't understand how to copy the errors out of the browser console. Any tips. I do see related errors, but not sure how to get the what is helpful over here. Below are the error messages and the lines of code.

H5P Chart - Instance undefined error on this line

else if(instance.$!==undefined&&instance.$.trigger!==undefined){instance.$.trigger(eventType);}};H5P.on=function(instance,eventType,handler){if(instance.on!==undefined){instance.on(eventType,handler);}

H5P Chart - Unable to find constructor for: H5P.Chart 1.0

return instance;};H5P.error=function(err){if(window.console!==undefined&&console.error!==undefined){console.error(err.stack?err.stack:err);}};H5P.t=function(key,vars,ns){if(ns===undefined){ns='H5P';}

H5P Multiple choice - Missing ';' before statement

EJS.Helpers.prototype.date_tag=function(name,value,html_options){if(!(value instanceof Date)) value=new Date() var month_names=["January","February","March","April","May","June","July","August","September","October","November","December"]; var years=[],months=[],days=[]; var year=value.getFullYear(); var month=value.getMonth(); var day=value.getDate(); for(var y=year-15;y<year+15;y++) { years.push({value:y,text:y}) } for(var m=0;m<12;m++) { months.push({value:(m),text:month_names[m]}) } for(var d=0;d<31;d++) { days.push({value:(d+1),text:(d+1)}) } var year_select=this.select_tag(name+'[year]',year,years,{id:name+'[year]'}) var month_select=this.select_tag(name+'[month]',month,months,{id:name+'[month]'}) var day_select=this.select_tag(name+'[day]',day,days,{id:name+'[day]'}) return year_select+month_select+day_select;}

H5P Multiple choice - Unable to find constructor for: H5P.MultiChoice 1.6

return instance;};H5P.error=function(err){if(window.console!==undefined&&console.error!==undefined){console.error(err.stack?err.stack:err);}};H5P.t=function(key,vars,ns){if(ns===undefined){ns='H5P';}

H5P Multiple choice - Instance is undefined

else if(instance.$!==undefined&&instance.$.trigger!==undefined){instance.$.trigger(eventType);}};H5P.on=function(instance,eventType,handler){if(instance.on!==undefined){instance.on(eventType,handler);}

Yes I tried turning off compression for all the h5p js files, but that did not work. I am not sure why. However, disabling AdvAgg entirely for H5P nodes does solve my problem.

Drupal 7.50
Advanced CSS/JS Aggregation 7.x-2.18
H5P - Create and Share Rich Content and Applications 7.x-1.18
Quiz 7.x-4.0-rc2
+100 other modules

I have attached a list of the H5P files, but I don't think that will help. I was not able to fix the problem by excluding compression for a particular file, but only by turning compression completely off for H5P Chart and Multiple Choice.

I used this code which forces no aggregation for all H5P types and all Quiz questions. It is a brute force solution, but it works.

function custom_module_page_alter() {
/*** Get the current active node ***/
$node = menu_get_object();
if (!empty($node->type) && ($node->type == 'h5p_content' || ($node->type == 'quiz' && arg(2)=='take'))) {
	$GLOBALS['conf']['advagg_js_compressor'] = 0;
}
}

Also see attached screen shots.