DynamicallyFieldableEntityStorageInterface::onBundleRename() has been removed and moved to a listener. See https://www.drupal.org/node/2346455 for more information.

CommentFileSizeAuthor
#5 2802563-2-removed-onbundlerename.patch1.2 KBtemkin

Comments

slashrsm created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: Unassigned » dishabhadra
dishabhadra’s picture

dishabhadra commented

Hi,

I am interested to submit the patch. So it would be helpful if someone help me out and provide me the more info.

jcisio’s picture

jcisio commented

With #2172843: Remove ability to update entity bundle machine names the media bundle can't be renamed now. So you can simple remove the method. The empty MediaStorage class should be keep for backward compatibility.

temkin’s picture

temkin commented
Status: Active » Needs review
StatusFileSize
new 2802563-2-removed-onbundlerename.patch1.2 KB

I've compared this logic with node module, and it seems we are not allowed to change bundle type once it was created. See ConfigEntityBundleBase.php, preSave method. Therefore getting rid of that logic altogether. Patch attached.

temkin’s picture

temkin commented

Apologies, I didn't see previous comments. Was working on this issue for a couple of hours.

jcisio’s picture

jcisio commented
Status: Needs review » Reviewed & tested by the community

Patch seems good. Yes, it actually needs quite a few hours to dig into separate change records and issues a year ago.

dishabhadra’s picture

dishabhadra commented

Hi temkin,

No worries.

  • slashrsm committed c9a665d on 8.x-1.x authored by temkin 
    Issue #2802563 by temkin, dishabhadra, jcisio: Remove MediaStorage::...
slashrsm’s picture

slashrsm commented
Status: Reviewed & tested by the community » Fixed

Committed. I attributed all three in the commit message. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.