Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

Status: Active » Needs review
markhalliwell’s picture

Status: Needs review » Needs work

The log-in icon I can get on board with, not so much with the class to turn the button green. If anything, it should really be primary.

markhalliwell’s picture

Title: Add 'Success' class and 'log-in' Glyphicon to 'Log in' button » Add "primary" class and "log-in" Glyphicon to "Log in" button
bandanasharma’s picture

Status: Needs work » Needs review
FileSize
755 bytes

Added patch, In the patch change success class to primary.

yas’s picture

@markcarver

Before I posted the proposal, first I thought "primary" class. In theory, yes, It seemed to be fine. However I prefer "success", which is green because I feel "primary" class, which is blue, is lower profile since the default URL link color is blue. In Bootstrap, a submit button is "success" class, which is green. The user experience starts with login button, therefore I thought "success" (green) is even more consistent and suitable for this login button. I wanted to respect such UX.

There looks no rule to apply "primary" or "success" to login for the a web site using Bootstrap. I searched google image with a keyword "login glyphicon", they are voting half and half before I proposed the first patch. That is, some sites employ "primary" that is "blue" for login button, on the other hand, some sites "success" that is "green". I checked several major sites such as Facebook, Twitter, Google, LinkedIn and d.o. and found they apply the site's color scheme. Especially the login button color of d.o. is green, but it looks naturally matching the color scheme of d.o. Note that d.o. employ "green" for buttons, and "blue" for links.

Attached screenshots are my site's login screen with "primary" or "success". Hope that helps.

markhalliwell’s picture

...and found they apply the site's color scheme

That is why it should be primary, because the primary color of a site can change; it isn't always necessarily "blue".

  • markcarver committed e16f392 on 8.x-3.x authored by yas
    Issue #2801841 by yas, bandanasharma: Add "primary" class and "log-in"...
markhalliwell’s picture

Version: 8.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Needs work
yas’s picture

@markcarver,

Understood. And let me post the backport patch to backport to 7.x-3.x.

yas’s picture

Status: Needs work » Needs review
markhalliwell’s picture

Status: Needs review » Needs work

Missing the glyphicon addition in #10.

yas’s picture

Status: Needs work » Needs review
FileSize
734 bytes

Oh, sorry for my mistake. Hope this works.

  • markcarver committed 2020922 on 7.x-3.x authored by yas
    Issue #2801841 by yas, bandanasharma: Add "primary" class and "log-in"...
markhalliwell’s picture

Status: Needs review » Fixed
Issue tags: -needs backport to 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.