Closed (fixed)
Project:
Bootstrap
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2016 at 22:29 UTC
Updated:
29 Oct 2016 at 02:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
yasComment #3
markhalliwellThe log-in icon I can get on board with, not so much with the class to turn the button green. If anything, it should really be
primary.Comment #4
markhalliwellComment #5
bandanasharma commentedAdded patch, In the patch change success class to primary.
Comment #6
yas@markcarver
Before I posted the proposal, first I thought "primary" class. In theory, yes, It seemed to be fine. However I prefer "success", which is green because I feel "primary" class, which is blue, is lower profile since the default URL link color is blue. In Bootstrap, a submit button is "success" class, which is green. The user experience starts with login button, therefore I thought "success" (green) is even more consistent and suitable for this login button. I wanted to respect such UX.
There looks no rule to apply "primary" or "success" to login for the a web site using Bootstrap. I searched google image with a keyword "login glyphicon", they are voting half and half before I proposed the first patch. That is, some sites employ "primary" that is "blue" for login button, on the other hand, some sites "success" that is "green". I checked several major sites such as Facebook, Twitter, Google, LinkedIn and d.o. and found they apply the site's color scheme. Especially the login button color of d.o. is green, but it looks naturally matching the color scheme of d.o. Note that d.o. employ "green" for buttons, and "blue" for links.
Attached screenshots are my site's login screen with "primary" or "success". Hope that helps.
Comment #7
markhalliwellThat is why it should be
primary, because the primary color of a site can change; it isn't always necessarily "blue".Comment #9
markhalliwellComment #10
yas@markcarver,
Understood. And let me post the backport patch to backport to 7.x-3.x.
Comment #11
yasComment #12
markhalliwellMissing the glyphicon addition in #10.
Comment #13
yasOh, sorry for my mistake. Hope this works.
Comment #15
markhalliwell