At many places inside classes there are t() functions present, Which actually should be $this->t().

CommentFileSizeAuthor
#15 translations_replace-2801121-15.patch6.6 KBmglaman
#12 translations_replace-2801121-12.patch7.58 KBandriyun
#9 interdiff-2801121-5-9.txt4.68 KBandriyun
#9 translations_replace-2801121-9.patch7.11 KBandriyun
#5 Translations_updated-2801121-5.patch12.16 KBkunalkursija
#2 Translations-2801121-2.patch6.97 KBkunalkursija

Comments

kunal.kursija created an issue. See original summary.

kunalkursija’s picture

kunalkursija commented
Assigned: kunalkursija » Unassigned
Status: Active » Needs review
StatusFileSize
new Translations-2801121-2.patch6.97 KB

Attaching Patch

Status: Needs review » Needs work

The last submitted patch, 2: Translations-2801121-2.patch, failed testing.

The last submitted patch, 2: Translations-2801121-2.patch, failed testing.

kunalkursija’s picture

kunalkursija commented
Status: Needs work » Needs review
StatusFileSize
new Translations_updated-2801121-5.patch12.16 KB

Attaching Updated Patch.

Status: Needs review » Needs work

The last submitted patch, 5: Translations_updated-2801121-5.patch, failed testing.

The last submitted patch, 5: Translations_updated-2801121-5.patch, failed testing.

andriyun’s picture

andriyun commented
Assigned: Unassigned » andriyun
andriyun’s picture

andriyun commented
Status: Needs work » Needs review
StatusFileSize
new translations_replace-2801121-9.patch7.11 KB
new interdiff-2801121-5-9.txt4.68 KB

There is no t() method for BrowserTestBase abstract class
We can use t() to translate strings

Status: Needs review » Needs work

The last submitted patch, 9: translations_replace-2801121-9.patch, failed testing.

The last submitted patch, 9: translations_replace-2801121-9.patch, failed testing.

andriyun’s picture

andriyun commented
Status: Needs work » Needs review
StatusFileSize
new translations_replace-2801121-12.patch7.58 KB
andriyun’s picture

andriyun commented
Assigned: andriyun » Unassigned
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks good

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new translations_replace-2801121-15.patch6.6 KB

Re-roll

  • mglaman committed 84ddb8c on 8.x-1.x authored by andriyun 
    Issue #2801121 by andriyun, kunal.kursija, mglaman: Translations:...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks, everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.