We define an isHidden() method for processor-added properties, but then completely ignore it in the UI (probably after one of the refactorings in this area).

CommentFileSizeAuthor
#4 2800011-4--hide_hidden_properties.patch1.57 KBdrunken monkey
#4 2800011-4--hide_hidden_properties--tests_only.patch687 bytesdrunken monkey
#4 2800011-4--hide_hidden_properties--interdiff.txt687 bytesdrunken monkey
#2 2800011-2--hide_hidden_properties.patch980 bytesdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Active » Needs review
FileSize
2800011-2--hide_hidden_properties.patch980 bytes

Simple fix.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented

Should we also add a test for that? I think an integration test should suffice to cover this.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
2800011-4--hide_hidden_properties--interdiff.txt687 bytes
2800011-4--hide_hidden_properties--tests_only.patch687 bytes
2800011-4--hide_hidden_properties.patch1.57 KB

You're right on both counts, of course. Thanks!

The last submitted patch, 4: 2800011-4--hide_hidden_properties--tests_only.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs review » Reviewed & tested by the community

test-only fails, test is very small and looks very readable. Great work!

  • drunken monkey committed 7640c7b on 8.x-1.x 
    Issue #2800011 by drunken monkey, borisson_: Fixed display of hidden...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

OK, thanks for reviewing and the suggestion!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.