Apart from #2776659: Remove calls to deprecated Utility methods, we should also make sure we have no other deprecated methods/functions lying around in the code once we create the first release candidate.

CommentFileSizeAuthor
#2 search_api-remove_deprecated_methods-2795861-2-D8.patch3.69 KBsinn

Comments

drunken monkey created an issue. See original summary.

sinn’s picture

sinn commented
Status: Active » Needs review
StatusFileSize
new search_api-remove_deprecated_methods-2795861-2-D8.patch3.69 KB

Deprecated methods apart Utility class are:

  • \Drupal\search_api\Display\DisplayInterface::getPath()
  • \Drupal\search_api\Processor\ProcessorPluginBase::filterForPropertyPath()
  • \Drupal\search_api\Processor\ProcessorPluginBase::extractItemValues()

Usage of these methods wasn't found, so they have been just removed.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Looks good, thanks a lot!
Committed.
It probably won't happen anymore, but if we deprecate other methods and want to remove them before RC, we just have to re-open this issue (or a new one):

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.