Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Sep 2016 at 14:36 UTC
Updated:
25 Jan 2017 at 20:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gábor hojtsyHere is a start!
Comment #3
chx commentedMigrations now automatically find which modules they depend on (aka the unicorn issue at #2560795: Source plugins have a hidden dependency on migrate_drupal before #217 renamed it)
Comment #4
dawehnerI'll work quickly one stuff around REST
Comment #5
dawehnerComment #6
chx commentedThere's #1267508: Subselects don't work in DBTNG conditions, except when used as value for IN been around long enough... or was that 8.3 only at the end? Perhaps #2384459: Add entity query condition for delta in EFQ as well
Comment #7
timmillwood- Remove white space
- Adding more context to content moderation
Comment #8
xjmThanks @Gábor Hojtsy, @dawehner, @timmillwood, and @chx!
#1267508: Subselects don't work in DBTNG conditions, except when used as value for IN was 8.3.x only. #2384459: Add entity query condition for delta in EFQ was backported to 8.1.x, but probably could make sense in the 8.2.x CHANGELOG since it wasn't in the 8.1.x ones.
Comment #9
xjmI also tagged #2560795: Source plugins have a hidden dependency on migrate_drupal for the release notes, thanks @chx.
Comment #10
xjmThere will be a third one now: #1999722: [policy] Define coding standards for anonymous functions (closures)
Comment #11
xjmI think we should add something here about numerous textual improvements in the UI. (No individual one is worth mentioning, but the aggregate is nice.)
Minor: capitalize "Moderation" and add a period at the end of the last sentence. Edit: And also it needs a serial comma after "Archived".
Comment #12
star-szrMinor: "Improvest" sounds like an awesome adjective but I think it's a typo? :)
Also, the bullets below this point aren't indented the same as the other bullets.
Comment #13
effulgentsia commentedMaking some changes to improve consistency with the 8.1.0 section of the changelog. Still working on it, but here's some work in progress. I have not yet addressed the comments on this issue.
Comment #14
effulgentsia commentedSome more changes. Not all issue comments have yet been addressed, but what do you all think of this structure?
Comment #15
effulgentsia commentedThe line between these 2 categories is pretty blurry. Initially, I thought it'd be clearer. I'm concerned about putting 7+ items into one category since I think that would be too much cognitive load, but I'm open to ideas on if/how to improve this.
Comment #16
cilefen commentedCan we be consistent about the vendor libraries by using the full name, the packagist name, or both?
By that I mean:
Not sure what that would mean for JS assets, maybe the Drupal libraries machine name if anybody cares. I'm not sure if I care that much about this ;-)
Comment #17
xjmThese are all REST-specific improvements, so I don't think we should separate this out unless we're also going to add all other DX improvements to 8.2.x here as well.
Edit: Also, I consider even "user"-facing REST/API-first improvements to be developer experience, TBH. I'd just include these three in the REST category, because it's unclear what the importance is otherwise. I think a long single list for decoupled sites is a good thing, because then people can see at a glance the things they hated about REST in 8.1.x and go "hey, we're good now, let's use 8.2.x." :)
Comment #18
xjmOverall, the updated patch reads well.
Comment #19
dawehnerYeah, I think some of them are actually a bit borderline. Like CORS is certainly mostly useful in the context of decoupled sites.
Comment #20
effulgentsia commentedOk, +1 to merging those two sections, per #19.
Here's some additional cleanup for #16 and other minor tweaks.
Comment #21
effulgentsia commentedThis adds lines for #3 and #8. I think the only feedback on this issue not yet incorporated is #11.1:
I'm not familiar with what these improvements were, so not sure how best to summarize them in a single sentence, or which category to put them into. Any ideas?
Comment #22
xjmI would put it under this category since the majority of them are on administrative pages. Maybe something simple like:
https://www.drupal.org/project/issues/search/drupal?project_issue_follow... includes many of the issues.
Comment #23
xjmMaybe we can also include #2513402: Any time a user creates a thing and saves, display a link to the thing created in the status. somewhere? I'd forgotten about that one.
Comment #24
xjmThis is missing the closures issue. OTOH that one is currently in limbo because we might not have sufficient support in coder yet.
I read "Tasting improvements". Seems fitting. ;)
Comment #25
xjmHm this point is not really clear. Maybe:
"Whenever a new entity is created, a link to it is provided in a status message, for easy access the new content regardless of the form workflow."
Comment #26
star-szrYeah #25 tripped me up too.
Comment #27
Anonymous (not verified) commentedtypo: 2016
Comment #28
wim leerssounds difficult.
What about:
Comment #29
wim leers-> is "to output" a verb?
I read this as "if you create an entity with a link… then you get feedback".
s/CKEditor dialogs/CKEditor-native/
… because this only affects dialogs like those for
<table>— the image and link plugins for CKEditor that Drupal includes already use Drupal dialogs. This just improves the 5% case (if even that).I honestly don't think this belongs in the changelog.
I don't see how this affects site administration — it affects scalability.
Why is "Cross" capitalized, but nothing else? Either nothing, or all words in the "CORS" acronym should be capitalized.
Should this mention "DX"?
Comment #30
xjmI think CKeditor just got updated too.
Comment #31
gábor hojtsy#2797427: Update CKEditor library to 4.5.11 is the CK issue.
Comment #32
effulgentsia commentedAddressed all the feedback since #21.
Except:
Comment #33
alexpottGiven that this has been generated from the automatic release notes I can only really assume it is complete. However, nothing is jumping out at me as glaringly missing. I've reviewed the content and also nothing appears to be incorrect.
There's been some discussion about which wording is better. Perhaps
Improved REST API and decoupled site building features:encompasses all points.Comment #34
alexpottAddressing #33.
Comment #35
catchCan we just call this REST? There's nothing in here that's not in the REST module.
#2699627: url.path cache context for breadcrumbs is unnecessarily granular was backported to 8.1.x, but if we're mentioning the page cache we could mention this too - resolves the same general issue.
Comment #36
dawehnerHere are some more:
Comment #37
xjmI'll incorporate things for #35 and #36.
Comment #38
klausiNote that compiling this changelog would be a bit easier if we would do #2802947: [meta] Use the Git commit message format from AngularJS.
Then we could pre-compile a list of all changes per module/subsystem automatically from the git log and beautify it from there.
Comment #39
xjmIncorporates the additional suggestions for #35 and #36. I did not change the header for REST. I agree that it's valuable to specifically say "REST improvements" since that's what they are, but I suppose it's also useful to provide more context for a general site-building audience (which is presumably why @effulgentsia changed this in #20). Including both terms per @alexpott's suggestion is probably fine.
Comment #40
xjm@klausi, I don't think that actually helps us because this is a curated list of important changes, not the entire commit log which is hundreds and hundreds of issues long. The curation is the hard part, not the categorization.
Comment #41
wim leerss/mechanism/provider/
Actually this gets it wrong. The "less verbose configuration structure" is indeed optional, but it's the new default. It's now the original (complex/detailed/verbose) configuration structure that is opt-in.
So, we changed the default complexity. The old structure is opt-in.
So, what about this:
Comment #42
klausi@xjm: sure, the final changelog would still be a manually curated list. But in order to actually know what to put in the list you can look at the compiled automatic changelog and it will give you a grouped list of changes. You immediately see in what subsystem many changes happened and it also helps to not forget about things.
Comment #43
xjmAddresses #41.
Comment #44
xjm@catch pointed out that "decoupled site building features" can be misleading because that can be misread as decoupled features for site builders, which is a specific audience we define, rather than as features for building decoupled sites.
Comment #45
cilefen commentedUpdated "Outside In" to "Settings Tray" with a note on its machine name.
Comment #46
gábor hojtsyThanks for the update @cliefen.
Read the whole thing from start to end again. Looked at the release note in the works and where it had comments on wording that was not the exact same words we use here, so those comments do not apply. Looks good to me :)
Added a note on #2810347: [policy, no patch] Mark migrate.module as beta stability if that does land in 8.2.0 and after this, then that needs to update the changelog too.
Comment #47
alexpottCommitted and pushed 380e763 to 8.3.x and efe135b to 8.2.x. Thanks!
Comment #50
mattltLooks like the paragonie/random_compat 2.0.2 vendor change hasn't quite made it yet, the original change was reverted.
https://www.drupal.org/node/2763787
Thanks,
•• matt
Comment #51
alexpott@mattlt nice spot! Created #2811357: Fix CHANGELOG.txt for 8.2.0 to remove paragonie/random_compat update
Comment #53
webchickHere's an issue for 8.3.0: #2846830: Add changelog for Drupal 8.3.0