We currently have an EntityStoreInterface used by Order, which has getStore and setStore.
But it's not really reusable, cause all other entities (products, promotions, etc) actually need getStores and setStores.

So, let's remove EntityStoreInterface, move the relevant methods to OrderInterface, then implement an EntityStoresInterface with the right methods, used by products and promotions.

CommentFileSizeAuthor
#3 replace-EntityStoreInterface-EntityStoresInterface-2794485-3.patch8.2 KBmiteshmap

Comments

bojanz created an issue. See original summary.

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Assigned: Unassigned » miteshmap
miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Assigned: miteshmap » Unassigned
Status: Active » Needs review
StatusFileSize
new replace-EntityStoreInterface-EntityStoresInterface-2794485-3.patch8.2 KB

PR - https://github.com/drupalcommerce/commerce/pull/482

  • bojanz committed 923d672 on 8.x-2.x authored by miteshmap 
    Issue #2794485 by miteshmap, bojanz: Remove EntityStoreInterface, add...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Finished and committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.