In #2472419: Use core CSS for admin UI filter/processor stages columns, we discuss using Core's CSS from #2471791: Improve the CSS layout framework for Drupal's admin interface for the three-column layout for stages in the "Processors" tab. However, since that doesn't seem to go anywhere in the foreseeable future, for now we should just fix the CSS to the best we can manage.

My suggestion from the other issue:

.search-api-stage-wrapper.form-item {
  width: 32.66%;
  box-sizing: border-box;
}

.search-api-stage-wrapper.form-item:last-child {
  margin-right: 0;
}

Comments

drunken monkey created an issue. See original summary.

kamalrajsahu21’s picture

Status: Active » Needs review
StatusFileSize
new367 bytes

Here is the patch for the same. Please check it.

Status: Needs review » Needs work

The last submitted patch, 2: processors-css-fixes-2794093-2.patch, failed testing.

drunken monkey’s picture

Thanks for your work!
However, please create patches relative to the project's root directory, so Git (and the d.o test bot) can apply them correctly.
Also, instead of appending those definitions at the end, they should replace (part of) the existing definitions for the processor stages.

borisson_’s picture

Status: Needs work » Needs review
StatusFileSize
new412 bytes

Reroll attached.

drunken monkey’s picture

StatusFileSize
new820 bytes
new797 bytes

Thanks for the corrected patch!
However, this still didn't replace the old definitions. Here is a revision with my (improved) suggestions, and it seems to work great (at least under Linux on Firefox and Chromium).

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

  • drunken monkey committed 15c82df on 8.x-1.x
    Issue #2794093 by drunken monkey, borisson_, kamalrajsahu21: Fixed the...
drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Good to hear, thanks for testing/reviewing!
I guess if it doesn't work correctly on some browsers, people will come and complain. So, committed.
Thanks again, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.