Order owner Discount

So, as I understand it, the current process is not sufficient because we need to apply different pricing/discount rules depending on who the order owner is, well before the payment stage, as products are added and the prices are calculated right? Because, basically, what is happening right now is, when we set the email of the customer for the POS transaction, it only sets the order->email part. Then, once the order is paid for and the transaction is complete, it then, assigns the user as the order owner.

Correct me if I'm wrong, but, instead of waiting till the payment part, if we set the order owner right away, as the customer email gets updated, shouldn't this fix the problem?

I've got to admit, I had no idea when I initially committed to working on this what it really meant. But as I started working on it, things got a lot clearer.

So as it is right now, with the Discount module, we could only apply order and product discounts depending on the LOGGED in user. However, there wasn't a condition to apply discounts based on the owner of the order. So the first thing on the agenda was to introduce a new condition ('Order Owner') that would allow us to apply order/product discounts depending on who the owner of the order was, which is essentially what we want in POS. Because, POS transactions are almost always made on behalf of another user and NOT the logged in user.

The second thing we needed to do once we added the new discount condition was, we needed to change the default behaviour of POS where if a customer email address was added/changed, it wouldn't apply to the order until after the payment submit stage. So, we needed to apply the new customer to the order, immediately.

Then, the tricky part was, every time the order owner changed we needed to make sure all the line items prices were recalculated and the entire order refreshed, and reflected in the UI.

So, now, we have a working version of the POS loading the calculated prices for the order owner instead of the logged in user.

@shabana.navas I applied patch in #6 and cleared cache. Then I added two products using pos interface then I was applying discounts for individual product and whole order but nothing was happening. You can see in below gif image.

I am getting below notice and warning in recent log -

Notice: Undefined index: price_edit in commerce_pos_discount_validate_product_discount() (line 541 of /var/www/d7_test/sites/all/modules/commerce_pos/modules/discount/commerce_pos_discount.module).

Warning: Division by zero in commerce_pos_discount_validate_product_discount() (line 547 of /var/www/d7_test/sites/all/modules/commerce_pos/modules/discount/commerce_pos_discount.module).

Please tell me if I am doing anything wrong to test this patch.

Thanks

Oops! Thanks for catching that Saurabh. Forgot to take out an un-needed line. Can you test it now?

I applied patch and cleared cache. Then created discount as mentioned in gif #6. When I select a product and enter customer's email. It creates the discount for that customer. But after that, if I apply product wise discount then product price changes automatically. Gif image is attached for more understanding of bug.

Saurabh I believe this is the way the discounts work. What you are doing there is trying to double up on a discount. So you are trying to apply two discounts to a single product. I don't think this is a bug with the patch but the way discounts work. It basically cancels out the first one.

@smccabe Maybe you can chime in.

I believe I might need to re-roll this patch against the latest versions.

Saurabh if you've got time, could you re-roll this patch against the latest 7.x version of POS? It should be pretty straightforward.

@shabana.navas Sure, will do it.

Rerolled patch. Please review.

@sharif.tanveer Ah! sorry, out of habit we were creating patch against 7.x-2.x branch. But this patch was meant to be for 7.x-2.0-beta7 branch. Rerolled the patch, please confirm if this works for you now.

@sharif.tanveer commerce_pos_transaction_form is the function name and its located in commerce_pos.transaction.inc file and that file is in the includes folder.

Patch in #24 is for the 7.x-2.x branch.

Hey Sharif, you want to set it to RTBC, not fixed. RTBC means you have tested it and it works, fixed means it has actually been committed into the code.

I'll try to commit this tomorrow.

Patch re-rolled against latest 7.x-2.x. Applies to both 7.x-2.x-dev and 7.2 version. Please test this out.