Run coding standards over the entire framework when no major issues are active

CommentFileSizeAuthor
#16 2792897-cs-2.patch36.06 KBdpi
#14 2792897-cs.patch36.17 KBdpi
#10 php-short-syntax.patch24.49 KBdpi
#7 coder.txt93.68 KBdpi
#5 coding-style-2792897-5-3dbf58c.patch132.94 KBdpi
#3 coding-style-2792897-3-4276e5d.patch85.52 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: Unassigned » dpi
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new coding-style-2792897-3-4276e5d.patch85.52 KB

For testbot only.

almaudoh’s picture

almaudoh commented

We should give credit to @aditya_anurag from the other issue

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new coding-style-2792897-5-3dbf58c.patch132.94 KB

I reject your proposal :)

This patch has all the manual fixes. Mostly docs I have to create.

dpi’s picture

dpi
Location Perth, Australia
commented

https://github.com/dpi/smsframework/pull/55

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new coder.txt93.68 KB

Attaching initial coder report

  • dpi committed 82c13e8 on 8.x-1.x 
    Issue #2792897 by dpi: Coding standards
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Fixed » Needs review
StatusFileSize
new php-short-syntax.patch24.49 KB

Short array syntax arrays

  • dpi committed d93f7d2 on 8.x-1.x 
    Issue #2792897 by dpi: Convert arrays to short syntax.
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 2792897-cs.patch36.17 KB

Status: Needs review » Needs work

The last submitted patch, 14: 2792897-cs.patch, failed testing. View results

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new 2792897-cs-2.patch36.06 KB
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review

  • dpi committed bbe5360 on 8.x-1.x 
    Issue #2792897 by dpi: Coding standards
dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: dpi » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.