Problem/Motivation

Until now we had field diff builder plugins only declared as Plugin/Diff.

Now we want to introduce a second namespace for Layout and we have a clashing problem.

Proposed resolution

Rename Plugin/Diff to Plugin/diff/Field.
Then we have a cleaner pattern for other plugin types and a nice folder structure.

Note, short after this change, we need to release another alpha to allow other modules catching up with this name change.

CommentFileSizeAuthor
#3 rename_plugin_diff_to-2791943-3.patch8.28 KBjohnchque
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker created an issue. See original summary.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

The release short after is needed. Otherwise the other modules won't be able to have passing tests when catching up with this change.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Active » Needs review
FileSize
rename_plugin_diff_to-2791943-3.patch8.28 KB

Made those changes. Also update the documentation.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

This looks clean to me.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

So yeah, let's fix the namespaces now or never. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.