Wrong links in tours (eg. Language and Locale)

Can you please upload the screen shot

@Chi ! you were correct, [site:url] token already ends with a trailing slash.
Corrected the URLs, please find the attached patch.

Thanks,
Nishad

At first I wondered if the behaviour of the site:url token had changed in Drupal 8 compared to 7. It has not:

Psy Shell v0.7.0 (PHP 7.0.7 — cli) by Justin Hileman
>>> $result = \Drupal::url('<front>', array(), ['absolute' => TRUE], TRUE);
=> Drupal\Core\GeneratedUrl {#12633}
>>> $result->getGeneratedUrl();
=> "http://drupal8alt.dev/"
>>> \Drupal::VERSION
=> "8.3.0-dev"

Psy Shell v0.7.0 (PHP 7.0.7 — cli) by Justin Hileman
>>> url('<front>', ['absolute' => TRUE])
=> "http://default/"
>>> DRUPAL_VERSION;
PHP error:  Use of undefined constant DRUPAL_VERSION - assumed 'DRUPAL_VERSION' on line 1
>>> VERSION
=> "7.51-dev"

So the change looks correct..

+++ b/core/modules/language/config/optional/tour.tour.language-add.yml
@@ -25,5 +25,5 @@ tips:
-    body: '<p>Now that you have an overview of the "Add languages" feature, you can continue by:<ul><li>Adding a language</li><li>Adding a custom language</li><li><a href="[site:url]/admin/config/regional/language">Viewing configured languages</a></li></ul></p>'
+    body: '<p>Now that you have an overview of the "Add languages" feature, you can continue by:<ul><li>Adding a language</li><li>Adding a custom language</li><li><a href="[site:url]admin/config/regional/language">Viewing configured languages</a></li></ul></p>'

The original version reads nicer - but the new version is definitely correct. However there are more tours to fix - we should fix all the tours in core. Given this is a configuration change we also should consider an upgrade path. However, given that the links work and just cause a 302 I think we shouldn't bother with that.

Have corrected in all tours in the core with this new patch.

Thanks
~Chirag

As per the previous finding there were only issue in language and local module.
So this issue was considered for language module.

For local module, another issue https://www.drupal.org/node/2797663 was logged.

Thanks,
Nishad

Hi,

Tested this patch in 8.2 dev see attached screen shot before the patch was applied and after. All is good.

"[site:url]/" not found in the code anymore. Looks good - updating issue credits.

Committed 554852c and pushed to 8.3.x. Thanks!

Leaving to be cherry-picked into 8.2.x once 8.2.0 is released.

Patch #11 works and still applies cleanly for 8.2.

I had been looking at this as part of the Mentored sprints at DC Dublin 2016

Been looking at this as part of the Mentored Sprints at DrupalCon Dublin 2016.

Agree Patch #11 applies cleanly for 8.2.

Committed 52ecc26 and pushed to 8.2.x. Thanks!