In \Drupal\search_api\Plugin\IndexPluginBase::__construct(), we currently have the following comment:
// @todo Change key to, e.g., '*index', to avoid potential collisions.
if (!empty($configuration['index']) && $configuration['index'] instanceof IndexInterface) {
$this->setIndex($configuration['index']);
unset($configuration['index']);
}
Before we release a Beta version, we should decide whether we actually want to do this. I'd say it's probably a good idea – or can anyone think of a reason against it?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2791031-2--plugin_config_magic_index_key.patch | 6.47 KB | drunken monkey |
Comments
Comment #2
drunken monkeyAsked borisson_ for input on this, and he suggested using
'#index'instead of'*index'– which does sound like a much better idea.The attached patch implements this proposal.
Comment #3
borisson_Looks great!
Comment #5
drunken monkeyGood to hear, thanks for reviewing!
Committed.