Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Aug 2016 at 16:57 UTC
Updated:
9 Feb 2017 at 21:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
temkin commented+1 for ctools update. Go PHP7!
Patch attached.
Comment #3
temkin commentedComment #4
cboyden commentedUpdated issue summary to reflect new releases for Panels and CTools.
Comment #5
cboyden commentedAttached is a patch to panopoly_core and an interdiff. This might require updating PHP versions, we'll see when the tests run.
Comment #6
cboyden commentedThe live preview test is failing consistently in the "Live preview should work when configuring a pane style" scenario, line 371 of livepreview.feature. See https://travis-ci.org/cboyden/panopoly/builds/168148433.
Comment #7
cboyden commentedLive Preview is not firing when the radio button for the test style is selected:
If you comment out the failing step, the rest of the test passes; the live preview updates successfully in the 2nd part of the test:
It's possible that live preview needs some adjustment in order to work with the new CTools.
Comment #8
cboyden commentedThe problem with live preview appears to be caused by the commit in this issue: #1823088: Autosubmit forms in modals are broken. There's a proposed patch in #2787045: Regression: Compatibility with Drupal 7 core version of jQuery broken which basically reverts the check for JQ version number and just does a strict === check for the string "undefined". Adding this patch to the CTools recipe allows the live preview test to pass.
Comment #9
cboyden commentedTests are passing, see https://travis-ci.org/cboyden/panopoly/builds/174070306.
Comment #10
cboyden commentedCTools 1.12 is here! Updated patch is attached.
Comment #11
cboyden commentedTests are passing except for the expected failures due to the Apps bug post-7.50. See https://travis-ci.org/cboyden/panopoly/builds/184361350.
Comment #12
dsnopekHere's a new version of this patch which adds the patch for #2790075: Not Authorized when managing flexible layout to fix for a Panels regression. If this passes tests, it's probably time to commit it!
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/188966025
Comment #14
dsnopekTests passed, so committed! Thanks, Everyone!
Comment #15
cboyden commentedThere's a critical regression in Panels 3.8 - see #2479879: Move 'panels_page_allowed_types' variable to a custom table.. Allowed types variables (that control what content can be added to Panels or Panelizer pages) are no longer exportable with Features. An update hook deletes existing variables. If any site using Panopoly has made changes to allowed types, and not exported them into code, they will lose data.
Comment #17
dsnopekUgh... Ok, reverting this for now!
Comment #18
dsnopekAdding the patch to revert #2479879: Move 'panels_page_allowed_types' variable to a custom table.. We'll see if the tests still like this one
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/193095189
Comment #19
cboyden commentedThe patch from #2479879: Move 'panels_page_allowed_types' variable to a custom table. #33 doesn't solve the problem - it reverts the code so that allowed_types config is still stored as variables, but it doesn't revert the update hook that deletes the variables. I added a patch that changes the update hook so that all it does is add the new table. New patch for the panopoly_core makefile is attached.
EDIT: Tests are passing, see https://travis-ci.org/cboyden/panopoly/builds/193492410.
Comment #20
dsnopekOk, this is looking good to me. Committing take two!