Comments

cboyden created an issue. See original summary.

temkin’s picture

StatusFileSize
new860 bytes

+1 for ctools update. Go PHP7!

Patch attached.

temkin’s picture

Status: Active » Needs review
cboyden’s picture

Title: Update CTools to 1.10 » Update CTools to 1.11 and Panels to 3.8
Issue summary: View changes
Status: Needs review » Needs work

Updated issue summary to reflect new releases for Panels and CTools.

cboyden’s picture

Status: Needs work » Needs review
StatusFileSize
new844 bytes
new720 bytes

Attached is a patch to panopoly_core and an interdiff. This might require updating PHP versions, we'll see when the tests run.

cboyden’s picture

Status: Needs review » Needs work

The live preview test is failing consistently in the "Live preview should work when configuring a pane style" scenario, line 371 of livepreview.feature. See https://travis-ci.org/cboyden/panopoly/builds/168148433.

cboyden’s picture

Live Preview is not firing when the radio button for the test style is selected:

When I select the radio button "Panopoly Test: Style with settings" with the id "edit-style-panopoly-test-settings-style"
And I wait for live preview to finish
Then I should see "This widget is patentedly awesome!" 
      The text "This widget is patentedly awesome!" was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

If you comment out the failing step, the rest of the test passes; the live preview updates successfully in the 2nd part of the test:

When I select "Terrible" from "Quality of this widget"
And I wait for live preview to finish
Then I should see "Avert your eyes! It's not even worth to cast your gaze upon this widget."

It's possible that live preview needs some adjustment in order to work with the new CTools.

cboyden’s picture

The problem with live preview appears to be caused by the commit in this issue: #1823088: Autosubmit forms in modals are broken. There's a proposed patch in #2787045: Regression: Compatibility with Drupal 7 core version of jQuery broken which basically reverts the check for JQ version number and just does a strict === check for the string "undefined". Adding this patch to the CTools recipe allows the live preview test to pass.

cboyden’s picture

cboyden’s picture

Title: Update CTools to 1.11 and Panels to 3.8 » Update CTools to 1.12 and Panels to 3.8
Issue summary: View changes
StatusFileSize
new961 bytes
new524 bytes

CTools 1.12 is here! Updated patch is attached.

cboyden’s picture

Tests are passing except for the expected failures due to the Apps bug post-7.50. See https://travis-ci.org/cboyden/panopoly/builds/184361350.

dsnopek’s picture

Related issues: +#2790075: Not Authorized when managing flexible layout
StatusFileSize
new1.04 KB

Here's a new version of this patch which adds the patch for #2790075: Not Authorized when managing flexible layout to fix for a Panels regression. If this passes tests, it's probably time to commit it!

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/188966025

  • dsnopek committed ea6a787 on 7.x-1.x
    Update Panopoly Core for Issue #2789503 by cboyden, temkin, dsnopek:...
dsnopek’s picture

Status: Needs review » Fixed

Tests passed, so committed! Thanks, Everyone!

cboyden’s picture

Status: Fixed » Needs work

There's a critical regression in Panels 3.8 - see #2479879: Move 'panels_page_allowed_types' variable to a custom table.. Allowed types variables (that control what content can be added to Panels or Panelizer pages) are no longer exportable with Features. An update hook deletes existing variables. If any site using Panopoly has made changes to allowed types, and not exported them into code, they will lose data.

  • dsnopek committed 6975448 on 7.x-1.x
    Revert "Update Panopoly Core for Issue #2789503 by cboyden, temkin,...
dsnopek’s picture

Ugh... Ok, reverting this for now!

dsnopek’s picture

Status: Needs work » Needs review
StatusFileSize
new1.17 KB

Adding the patch to revert #2479879: Move 'panels_page_allowed_types' variable to a custom table.. We'll see if the tests still like this one

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/193095189

cboyden’s picture

The patch from #2479879: Move 'panels_page_allowed_types' variable to a custom table. #33 doesn't solve the problem - it reverts the code so that allowed_types config is still stored as variables, but it doesn't revert the update hook that deletes the variables. I added a patch that changes the update hook so that all it does is add the new table. New patch for the panopoly_core makefile is attached.

EDIT: Tests are passing, see https://travis-ci.org/cboyden/panopoly/builds/193492410.

dsnopek’s picture

Status: Needs review » Fixed

Ok, this is looking good to me. Committing take two!

  • dsnopek committed 6bac116 on 7.x-1.x
    Update Panopoly Core for Issue #2789503 by cboyden, dsnopek, temkin:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.