Is there anything in the pipeline to port this module over to Drupal 8?

Joz

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jozzy_a created an issue. See original summary.

Rajab Natshah’s picture

+1 I'm with that .. We do need it very much.

Rajab Natshah’s picture

Assigned: Unassigned » Rajab Natshah
Status: Active » Needs work
Rajab Natshah’s picture

Title: Behat UI for Drupal 8 » Port [Behat UI] to Drupal 8
jozzy_a’s picture

Rajab I can help porting this module over to D8. Have you already started the porting?

Joz

Rajab Natshah’s picture

Yes, Joz

I will commit a new branch for that.
Any help will be rewarded.

It's good to see that we do have an interest in the module,
I only had just granted an access to commit #2823411: Offering to maintain Behat UI

I like to play in a group, Have collaborative work to have the Job done!!!

Thank you :)

jozzy_a’s picture

Happy to help :)

Have you managed to push up a D8 branch yet?

Joz

Rajab Natshah’s picture

Status: Needs work » Active

Active working on it.

Ericmaster’s picture

Is there any work in progress for this? I'm willing to help in porting this module to D8 as I think it will provide some value added to my client.

  • RajabNatshah committed 6487c8b on 8.x-1.x
    Issue #2788661: Starter work on Porting [Behat UI] to Drupal 8
    
Rajab Natshah’s picture

Hi Eric, Joz,
I have pushed my progress work.

Still many parts to work on.

Rajab Natshah’s picture

Assigned: Rajab Natshah » Unassigned
Status: Active » Needs review
Rajab Natshah’s picture

Version: 7.x-2.1 » 8.x-1.x-dev
Assigned: Unassigned » Rajab Natshah
Status: Needs review » Needs work
IT-Cru’s picture

@RajabNatshah : I have tested yesterday the current 8.x-1.x-dev branch and many things throws fatal errors and module does not work for D8. My idea was to build a behat_reports module, but then I found this module which could also work as base for my idea.

Do you plan currently any work on the D8 port? If not I could possible refactor the current D8 code to get it working.

Rajab Natshah’s picture

Hi Steffen,
Sorry, I did not have time to continue work on the port.
Any help is welcome for sure.
Karim and Caio are very collaborative and welcoming :)

IT-Cru’s picture

Hello together,

I've started working on a patch. I've currently separated the settings and running tests form. On the create test form I currently get a fatal error which I've doesn't fixed yet.

New settings form is working fine, but some settings like directory settings are missing yet.
Run tests form I will try to fix in the next days.

When running tests and settings form are working fine I attach the patch for review and discussion.

IT-Cru’s picture

First throw of my patch to fix broken D8 port. Running tests with behat pretty formatter is working fine. For HTML formatter I have used "elkan/behatformatter": "^1.0" because behat 3 does not provide a HTML formatter any more. HTML formatter is disabled by default on running tests form.

Not working yet:

  • Create new test form.
  • Kill process link (perhaps my test suite runs not long enough to kill it).
  • Code needs some more validation and exception handling.

The patch is very big. Perhaps it makes more sense to join as co-maintainer for D8 branch of the behat_ui module?

IT-Cru’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 17: behat_ui-fix_D8_port-2788661-17.patch, failed testing. View results

IT-Cru’s picture

Status: Needs work » Needs review
FileSize
30.31 KB

Fix missing or wrong stuff of #17 patch.

  • Fix missing BehatUiRunTests form.
  • Fix info YML file.

Rajab Natshah’s picture

Assigned: Rajab Natshah » Unassigned

Thank you Steffen,
Committed ... :)
We will take any work from your point of work

I will be testing this module in
Cucumber Management System

If you like Steffen we could collaborate work in the Cucumber Drupal profile project too

:)

Rajab Natshah’s picture

Oh Seems that we do have a new patch

  • RajabNatshah committed 1a8253f on 8.x-1.x authored by IT-Cru
    Issue #2788661 by IT-Cru, RajabNatshah: Port [Behat UI] to Drupal 8
    
  • RajabNatshah committed f0d026b on 8.x-1.x authored by IT-Cru
    Issue #2788661 by IT-Cru, RajabNatshah: Port [Behat UI] to Drupal 8
    
Rajab Natshah’s picture

Committed last patch #20
We will move foreword with more testing from last commit.
Before we go for Behat UI 8.x-1.0-alpha1

Rajab Natshah’s picture

Status: Needs review » Needs work

After testing:

Given that we have installed "Behat UI" module with Drupal "Standard" distribution
And we did not set the "Path to Behat binary" config
And we did not set the "Directory path where Behat configuration file (behat.yml) is located" config
When we go to "/admin/config/development/behat_ui/new"
Then we should be able to work a normal with no errors.

Not sure yet, we could have a behat.yml auto locater and Behat auto dedicated process.
An alert message could do the work. if we do not want to run not selected gherkin scripts.

IT-Cru’s picture

@RajabNatshah: I think a general behat.yml auto locator is not so good, because the behat config file could be located in very different places in projects. For example I have a behat.yml in every sites/example.com directory in my multisite setup for local testing of the specific site.

Do you think we should open separate issues for D8 branch for fixing run tests, new tests, settings form and other stuff?

I currently will try to figure out how to run only a special feature / suite during run tests.

Rajab Natshah’s picture

Yes Steffen with you on that.

An alert message could do the work

Just to let the user know that behat.yml is not set yet and a link in the message to set it.

For sure we could create more issues. for all new coming ideas of fixes.
I committed your work, so that we could continue work from your point of work progress.

Thank you :)

Rajab Natshah’s picture

Status: Needs work » Fixed
Rajab Natshah’s picture

Status: Fixed » Closed (fixed)