Incorrect media queries are used in custom-media.css and custom.js.

Now, when the screen width is 767px, the menu is not showing correctly.

CommentFileSizeAuthor
#6 drupal8_zymphonies_theme-incorrect-media-queries-2787951-6.patch1.58 KBbryandenijs
#5 js-indention.png7.46 KBbandanasharma
#4 after-patch-seems-ok.PNG154.85 KBbryandenijs
#3 before-patch.png172.13 KBbandanasharma
#3 after-patch.png87.17 KBbandanasharma
#2 drupal8_zymphonies_theme-incorrect-media-queries-2787951.patch1.01 KBbryandenijs
screenshot-incorrect-media-queries.PNG375.97 KBbryandenijs

Comments

BryanDeNijs created an issue. See original summary.

bryandenijs’s picture

bryandenijs
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new drupal8_zymphonies_theme-incorrect-media-queries-2787951.patch1.01 KB

This patch fixes the media queries.

bandanasharma’s picture

bandanasharma commented
StatusFileSize
new after-patch.png87.17 KB
new before-patch.png172.13 KB

#2 patch is apply successfully and working fine. But indentation issue in custom.js file. Attached the after and before image for reference.

bryandenijs’s picture

bryandenijs
Primary language Dutch
commented
StatusFileSize
new after-patch-seems-ok.PNG154.85 KB

#3 Not sure what you mean with "indentation issue in custom.js file".
Webpage looks good here, and custom.js is formatted correctly.

bandanasharma’s picture

bandanasharma commented
StatusFileSize
new js-indention.png7.46 KB

#4 output of the patch is correct but in the js file indention is fine on 4 space but when it change according to js standard 4 to 2 space then it is not proper. Please find the attached screenshot.

bryandenijs’s picture

bryandenijs
Primary language Dutch
commented
StatusFileSize
new drupal8_zymphonies_theme-incorrect-media-queries-2787951-6.patch1.58 KB

#5 Aha I see. This doesn't have anything to do with this issue or patch.
But since you are right, i created a new patch which will also solve the indenting/styling issue.

bandanasharma’s picture

bandanasharma commented

#6 Patch is apply successfully and file is looking good. It is nice patch. In the patch you comment \ No newline at end of file and remove the line. But there always should be a new line after the end of the code, if you see all core file their is line, Drupal code follow this process.

bandanasharma’s picture

bandanasharma commented
Status: Needs review » Reviewed & tested by the community
bryandenijs’s picture

bryandenijs
Primary language Dutch
commented

#7 Thanks for testing! And whoops, you're right about the newline at end of the file.. PhpStorm messed up I think.

zymphonies-dev’s picture

zymphonies-dev commented
Status: Reviewed & tested by the community » Fixed

Fixed and updated changes in latest release.

zymphonies-dev’s picture

zymphonies-dev commented
Status: Fixed » Closed (fixed)
zymphonies-dev’s picture

zymphonies-dev commented

Updated in latest release.