On some production sites the README.txt file is removed or the permissions make it not readable. This causes warning messages and the printer-friendly pages help is not available.
Print is only one of a handful of modules that uses the README.txt file for help information.
I will attach a patch to provide help when the README.txt file is not readable.
The other advantage is that the help is translatable.
Personally, I think it is better to provide help this way rather than displaying the README.txt as help info.
The patch supports both displaying the README.txt to be backwards compatible and help without the README.txt file.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | print_provide-help-when-readme-not-readable-2787263-4.patch | 4.85 KB | izmeez |
| #2 | print-provide-help-when-readme-not-readable-2787263-2.patch | 4.87 KB | izmeez |
Comments
Comment #2
izmeez commentedAttached is a patch for review.
Comment #3
izmeez commentedComment #4
izmeez commentedAttached is a re-roll of the patch in comment #2 against the latest 7.x-2.x-dev for review.
Comment #5
izmeez commentedComment #6
jcnventuraI'd rather get rid of embedding the README.txt file.
Comment #7
izmeez commented@jcnventura Sorry, I do not understand what it is you would rather like to see. I simply used what is currently provided as help. Maybe, you can be more explicit as to what you would like to see. Thanks.
Comment #8
jcnventuraRemove the if (is_readable($readme)) block and condition, and just use the help code you created.
Comment #10
jcnventuraThanks!