Improve display and settings in file widget with and without file_entity

As I'm not a File Entity user I haven't run into a lot of these issues, but the code in the patch makes sense to me so far. I'll need to manually test with File Entity, Core, and existing sites using complicated modules like File Browser before RTBC'ing. For now I did a short review:

1. @@ -151,6 +143,7 @@ class FileBrowserWidget extends EntityReferenceBrowserWidget {
          '#type' => 'select',
          '#default_value' => $this->getSetting('view_mode'),
          '#options' => $this->displayRepository->getViewModeOptions('file'),
   +      '#access' => $this->entityTypeManager->getDefinition('file')->hasViewBuilderClass(),
   

   We do this hasViewBuilderClass check a few times, can we move it to the top of the function and put the result into a variable?

2. @@ -54,13 +55,6 @@ class FileBrowserWidget extends EntityReferenceBrowserWidget {
      protected $configFactory;
    
      /**
   -   * The image factory service.
   -   *
   -   * @var \Drupal\Core\Image\ImageFactory
   -   */
   -  protected $imageFactory;
   -
   -  /**
   

   Nitpick, but we'll need to remove the import for ImageFactory as well.

3. +    // Had the preview column if we have one.
   +      $current['#header'][] = $this->t('Preview');
   

   Nit, comment needs to be indented, and s/Had/Add/, and move above if statement to match the next comment.

4. +      if ($display) {
   +        $current[$entity_id]['display'] = $display;
   +      }
   +      // Assume that the file name is part of the preview output if
   +      // file entity is installed, hide this column in that case.
   +      if (!$has_view_builder) {
   +        $current[$entity_id]['display'] = ['#markup' => $entity->label()];
   +      }
   

   I think this block can be consolidated, from reading this it seems like there could be a $display present, but if there's no view builder the entity label is used instead, which I think is unintended. Maybe just an else would work? I would also be happy with any additional change that makes the conditionals more readable and condensed, this widget has a lot of variations.

The manual review went well, I don't see any issues so far when using this patch. When testing File removal, make sure you apply #2786851: Removing entities in FileBrowserWidget is broken first as the remove button is currently broken in Entity Browser HEAD (but works in 8.x-1.0-alpha7). Once my review is addressed I can RTBC :)

Patch needs re-roll after recent commits.

Committed. Thanks!

Hate to have to revive this, but this patch seems to have caused an issue.

I have a Content type with an image field configured with file_browser that has been working fine for months. Then I updated to the latest version of entity_browser - 8.x-1.0-alpha9 and suddenly I could not see the preview image in the edit form.

I tracked it back to $has_view_builder, and specifically this element which now doesn't appear:

$element['preview_image_style'] = [
      '#title' => $this->t('Preview image style'),
      '#type' => 'select',
      '#options' => image_style_options(FALSE),
      '#default_value' => $this->getSetting('preview_image_style'),
      '#description' => $this->t('The preview image will be shown while editing the content. Only relevant if using the default file view mode.'),
      '#weight' => 15,
      '#access' => !$has_view_builder && $this->fieldDefinition->getType() == 'image',
    ];

Rolling back to 8.x-1.0-alpha8 fixed it, but I really don't want to be stuck with an out of date, fixed version in my composer.json.

note. I do not have file_entity installed.

Thanks glynnr

I seem to have the same problem of no preview image on the edit form widget.

Thanks Berdir

I initially opened a bug report at: https://www.drupal.org/node/2801163.

But then later found the comment from glynnr here which replicates what I've found.

It is tricky to work out whether to post the report In the Entity Browser or File Entity Browser issue queue.

I'm not doing anything custom. Just testing File Entity browser on a standard image field on a node using Drupal 8.2.0-rc1

The form display is setup as:
Preview with default
Entity browser: Browser for files (modal)
Selection mode: Append to selection

I can browse and add an image file with no problems. However the preview thumbnail is blank on the node add form and on the node edit form.

Thanks for your time.

Cheers

Dave