file should be code standard

CommentFileSizeAuthor
#13 codingstandards-2783253-13.patch5.88 KBMunavijayalakshmi
#10 codingstandards-2783253-10.patch11.39 KBMunavijayalakshmi
#8 coding_standards-2783253-8.patch12.03 KBMunavijayalakshmi
#6 user_default_page-2783253-5.patch3.34 KBnishantkumar155
#4 user_default_page-2783253-4.patch15.78 KBnishantkumar155
#3 user_default_page-2783253-3.patch7.24 KBnishantkumar155
#2 user_default_page-2783253-2.patch7.24 KBnishantkumar155
#2 user_default_page-2783253-2.patch7.24 KBnishantkumar155

Comments

nishantkumar155 created an issue. See original summary.

nishantkumar155’s picture

nishantkumar155 commented
StatusFileSize
new user_default_page-2783253-2.patch7.24 KB
new user_default_page-2783253-2.patch7.24 KB
nishantkumar155’s picture

nishantkumar155 commented
Assigned: nishantkumar155 » Unassigned
Category: Bug report » Task
Status: Active » Needs work
StatusFileSize
new user_default_page-2783253-3.patch7.24 KB
nishantkumar155’s picture

nishantkumar155 commented
StatusFileSize
new user_default_page-2783253-4.patch15.78 KB
ajay_reddy’s picture

ajay_reddy
Location Fremont, California, USA
commented
Status: Needs work » Reviewed & tested by the community
nishantkumar155’s picture

nishantkumar155 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new user_default_page-2783253-5.patch3.34 KB
imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Needs work

Please add the interdiff file as well while applying patches against previous patches. Easier to review.

  1. +++ b/composer.json
@@ -2,7 +2,9 @@
+  "keywords": [
+    "Drupal"
+  ],

    I don't think this should be in 3 separated line. Previous one was fine. 

  2. +++ b/composer.json
@@ -10,5 +12,5 @@
-  "require": { }

    This is the correct way.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Version: » 8.x-1.x-dev
Assigned: Unassigned » Munavijayalakshmi
Status: Needs work » Needs review
StatusFileSize
new coding_standards-2783253-8.patch12.03 KB
padma28’s picture

padma28 commented
Status: Needs review » Needs work

Lines should have no trailing whitespace at the end. Please look into this link https://www.drupal.org/docs/develop/standards/coding-standards

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Status: Needs work » Needs review
StatusFileSize
new codingstandards-2783253-10.patch11.39 KB
Pavan B S’s picture

Pavan B S commented
Assigned: Munavijayalakshmi » Pavan B S
Status: Needs review » Reviewed & tested by the community

Patch is working fine..

krknth’s picture

krknth commented
Status: Reviewed & tested by the community » Needs work 
+++ b/config/schema/user_default_page_config_entity.schema.yml
@@ -27,4 +27,4 @@ user_default_page.user_default_page_config_entity.*:
\ No newline at end of file

+++ b/src/Entity/UserDefaultPageConfigEntity.php
@@ -150,4 +150,4 @@ class UserDefaultPageConfigEntity extends ConfigEntityBase implements UserDefaul
\ No newline at end of file

+++ b/src/Form/UserDefaultPageConfigEntityDeleteForm.php
@@ -43,10 +43,9 @@ class UserDefaultPageConfigEntityDeleteForm extends EntityConfirmFormBase {
\ No newline at end of file

+++ b/src/Form/UserDefaultPageConfigEntityForm.php
@@ -188,5 +189,4 @@ class UserDefaultPageConfigEntityForm extends EntityForm {
\ No newline at end of file

+++ b/src/UserDefaultPageConfigEntityHtmlRouteProvider.php
@@ -91,5 +91,4 @@ class UserDefaultPageConfigEntityHtmlRouteProvider extends AdminHtmlRouteProvide
\ No newline at end of file

+++ b/src/UserDefaultPageConfigEntityListBuilder.php
@@ -45,5 +45,4 @@ class UserDefaultPageConfigEntityListBuilder extends ConfigEntityListBuilder {
\ No newline at end of file

+++ b/user_default_page.links.menu.yml
@@ -4,5 +4,4 @@ entity.user_default_page_config_entity.collection:
\ No newline at end of file

+++ b/user_default_page.module
@@ -88,10 +92,11 @@ function user_default_page_user_login($account){
\ No newline at end of file

Add new lines

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Pavan B S » Unassigned
Status: Needs work » Needs review
Issue tags: +Needs reroll
StatusFileSize
new codingstandards-2783253-13.patch5.88 KB

Rerolled the patch.

krknth’s picture

krknth commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.