Add aria-sort attribute to Views table output

Good catch!

Here we go with patch which adds aria-sort attribute to views table output.

Patch #6 Applied on branch 8.3.x-dev, Works fine.

Reroll of the original patch to work on 9.4.x. Will look into building a proper test to go along with this work.

Adding new aria-sort test to check the th contains a corresponding aria-sort value based on sort setting.

Another attempt at the patch file.

Fixed Drupal CS issue of patch #24.

Updated patch will resolve CSpell error.

Should remove row_header key that entered in #24.

Git issues with previous patch file, includes now test file and include, along with interdiff.

Changes method of testing if aria-sort attribute is set to ascending by using elementAttributeContains().

Fix phpcs spacing issues in comment with update in #30.

Updating the CSS selector as the AJAX base table uses Views Bulk Operations (VBO) which meant the first th was not in fact the title header and not sortable.

Hmm... any ideas? That final selector works when accessing the table via the browser console. Is there some sort of additional delay needed for the AJAX click?

It really seems like this should be working properly.

 $page->clickLink('Title');
 $session_assert->assertWaitOnAjaxRequest();
 $session_assert->elementAttributeContains('css', 'th.views-field-title', 'aria-sort', 'ascending');

Somehow uploaded only the test. My apologies.

A passing test. Setting to Needs review.

A 10.x-dev compatible patch

Fixing CCF

Thank you @NivethaSubramaniyan

Verified and tested patch#39 on Drupal 10.1.x-dev and its working fine.
Patch applied successfully.
Thank You.

Thank you @NivethaSubramaniyan #39 Applied patch on Drupal 10.1.x-dev and it is working fine.

Created a new fork and added back in the test that verifies the new sort works properly. That looks to have been accidentally dropped during the reroll.

Please test again so that perhaps this issue can be changed to Reviewed and Tested by the Community (RTBC).

Adding tag for WCAG 4.1.2

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Reviewing MR 3222 as that seemed the more correct one.

Rebased the branch but there are CI failures that will have to be addressed

Hiding the files to avoid confusion as the issue is being fixed in an MR now.

Removing credit from myself for the rebase.

Fixed failed commands on #48
Attached patch against Drupal 10.1.x

Hiding #50 as the issue is being addressed in the MR

Try To Fix the #50 Patch.

Fix The Custom CMD Patch Of mine.

New patch file to fix failing tests. Suggested to use patch files for tests since Gitlab branch testing seems stuck in the composer loop.

Can't you submit the changes to the MR? 3222 is having an issue because the code needs tweaked.

Think switching back n forth between MRs and patches causes noise and could delay this. just fyi.

Starting at comment #54 patches have started to be used. The existing MR 3222 claims it is mergeable but when one tries, it fails with a composer error.

That composer error seems related to a gitlab infrastructure snafu that occurred around the time the MR was updated. Now it seems stuck.

Refactored #54 patch with drupalcs reported issues fixed. Patch file for now until Gitlab composer issue for MR 3222 is addressed.

Removing the tests tag as they have been added.

But instead of adding a new file and bootstrapping a new instance think it would be best to extend an existing test.

Was searching around NodeAdminTest::testContentAdminSort. "Tests that the table sorting works on the content admin pages." think we could just add a line or two checking for the aria-label.

Verified this is working on Drupal 10.1 with a standard install.
Went to the admin content page
Verified I see aria-sort on the updated column
Clicked the column and aria-sort changed
Clicked a different column and aria-sort moved.

Thanks

Patch moves the aria-sort test into the existing NodeAdminTest PHP test as @smustgrave suggested, and removes the aria-sort specific test. Needs review to check if ->elementAttributeContains() method is enough for the testing needed.

Much better!

Please include an interdiff with the patches though.

Interdiff between patches #57 and #60. Thanks for the reminder @smustgrave.

Committed 4916764 and pushed to 10.1.x. Thanks!