CommentFileSizeAuthor
#5 phpcs_fixes-2781861-5.patch26.65 KBsuraj2012

Comments

kunal.kursija created an issue. See original summary.

kunalkursija’s picture

kunalkursija commented
Issue tags: +DrupalMumbaiCodeSprint16
kunalkursija’s picture

kunalkursija commented
Assigned: kunalkursija » Unassigned
suraj2012’s picture

suraj2012 commented
Assigned: Unassigned » suraj2012

Working on this issue

suraj2012’s picture

suraj2012 commented
Assigned: suraj2012 » Unassigned
Status: Active » Reviewed & tested by the community
StatusFileSize
new phpcs_fixes-2781861-5.patch26.65 KB

Added patch. The patch fixes everything except 2 issues in

FILE: ...s/unix_time_conversion/unix_time_conversion.helper_functions.inc
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
67 | ERROR | Type hint "array" missing for $date
67 | ERROR | Type hint "array" missing for $time
----------------------------------------------------------------------
If i add the type hint then the functionality breaks.

suraj2012’s picture

suraj2012 commented
Status: Reviewed & tested by the community » Needs review
dishabhadra’s picture

dishabhadra commented
Status: Needs review » Closed (duplicate)

Already phpcs issues are merged https://www.drupal.org/project/unix_time_conversion/issues/2874780

Closing the issue.