Unix Time Conversion module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#8 short_array_syntax-2874780-8.patch13.75 KBdhruveshdtripathi
#4 short_array_syntax-2874780-4.png110.75 KBamit.drupal
#3 short_array_syntax-2874780-3.patch12.61 KBdhruveshdtripathi
#2 short_array_syntax-2874780-2.patch11.24 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2874780-2.patch11.24 KB
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
FileSize
short_array_syntax-2874780-3.patch12.61 KB

Fixed whitespace warnings.

amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community
FileSize
short_array_syntax-2874780-4.png110.75 KB

Thanks @dhruveshdtripathi for patch

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually.
it is working fine. Moving to RTBC

kunalkursija’s picture

kunalkursija CreditAttribution: kunalkursija at Axelerant commented
Status: Reviewed & tested by the community » Needs work

Hi @Munavijayalakshmi @dhruveshdtripathi

I have created a new branch called 8.x-2.x, Where few other patches are applied as well and this branch will be used to create a 8.x-2.0 release.

So i tried to apply the patch there, But it failed.

Changing Status to `Needs Work`.

kunalkursija’s picture

kunalkursija CreditAttribution: kunalkursija at Axelerant commented

Just an update: Both #2 & #3 did not work for me on 8.x-2.x.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Assigned: Unassigned » dhruveshdtripathi
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
FileSize
short_array_syntax-2874780-8.patch13.75 KB

Hi Kunal

I clone 8.x-2.x branch and created following patch based on that. Please apply the following patch on 8.x-2.x branch. I made following changes:

  • Converted all the array() function to short array syntax
  • Removed few extra spaces
  • Added required new lines at the end of some files

kunalkursija’s picture

kunalkursija CreditAttribution: kunalkursija at Axelerant commented

Have committed to 8.x-2.x branch.
Thanks for #8 @dhruveshdtripathi.

kunalkursija’s picture

kunalkursija CreditAttribution: kunalkursija at Axelerant commented
Status: Needs review » Fixed

Changing Status.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.