Problem/Motivation

When I enable BEF on a taxonomy term exposed filter, and I choose to show it as a list of links (and not the default select-option list) JS breaks:

Uncaught TypeError: Cannot read property 'toLowerCase' of null(anonymous function) @ mefibs_bef.js?obnl9c:16each @ jquery.min.js?v=1.10.2:4each @ jquery.min.js?v=1.10.2:4(anonymous function) @ mefibs_bef.js?obnl9c:12each @ jquery.min.js?v=1.10.2:4each @ jquery.min.js?v=1.10.2:4attach @ mefibs_bef.js?obnl9c:11(anonymous function) @ drupal.js?obnl9c:76each @ jquery.min.js?v=1.10.2:4Drupal.attachBehaviors @ drupal.js?obnl9c:74(anonymous function) @ drupal.js?obnl9c:481c @ jquery.min.js?v=1.10.2:4fireWith @ jquery.min.js?v=1.10.2:4ready @ jquery.min.js?v=1.10.2:4q @ jquery.min.js?v=1.10.2:4

Proposed resolution

Proposing patch

Remaining tasks

Review

CommentFileSizeAuthor
#4 mefibs-fix_js_broken_if_select_as_links-2781571-4.patch1.09 KBzekvyrin
#3 mefibs-fix_js_broken_if_select_as_links-2781571-3.patch1.08 KBzekvyrin
fix_js_broken_if_select_as_links.patch940 bytesefpapado

Comments

efpapado created an issue. See original summary.

zekvyrin’s picture

zekvyrin commented
Status: Active » Reviewed & tested by the community

Had the same issue & tihs patch fixed it.

Thanks! :)

zekvyrin’s picture

zekvyrin commented
StatusFileSize
new mefibs-fix_js_broken_if_select_as_links-2781571-3.patch1.08 KB

Hm.. i had some weird cases where it wasn't a string either (was an array).

So I added another condition.

zekvyrin’s picture

zekvyrin commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new mefibs-fix_js_broken_if_select_as_links-2781571-4.patch1.09 KB

And of course.. coding standards...

  • berliner committed f053887 on 7.x-1.x authored by Zekvyrin 
    Issue #2781571 by Zekvyrin, efpapado: JS broken with BEF select as links...
berliner’s picture

berliner commented
Status: Needs review » Fixed

Committed to dev.

Thanks both of you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.