Problem/Motivation

I would like to use ERR + Paragraphs with Entity Pilot to deploy paragraph content between sites, but ERR uses revision_id in normalization which is not deployable. With #1812202: Add UUID support for entity revisions in a workable state it'd be good to start thinking about how we would do this.

Proposed resolution

Swapping the normalizer to use the revision_uuids.

CommentFileSizeAuthor
#7 interdiff.txt587 bytesacbramley
#7 2780395-7.patch10.74 KBacbramley
#4 interdiff.txt4.26 KBacbramley
#4 2780395-4.patch10.84 KBacbramley
#3 interdiff.txt5.9 KBacbramley
#3 2780395-3.patch12.64 KBacbramley
#2 2780395-1.patch7.91 KBacbramley

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley commented
Assigned: Unassigned » acbramley
StatusFileSize
new 2780395-1.patch7.91 KB

This is as far as I've got today on this. One thing that has me a bit confused is to test this I had to add the revision_uuid key to an ERR field (I'm using paragraphs). When I initially added it, I was getting strange results with the EFQ in the RevisionUuidResolver with the where condition being on the data table rather than the revision table.

This led to nothing ever being returned because the data table was always ahead of the revision table so the revision_uuids would never match. Changing the revision_uuid to "revisionable" fixed this after I tracked down the problem but not only does that not feel right, I think it's now causing issues when importing the paragraph entities since a new revision_uuid is generated on import instead of using the one that was exported.

acbramley’s picture

acbramley commented
StatusFileSize
new 2780395-3.patch12.64 KB
new interdiff.txt5.9 KB

Unit tests added for the resolver

acbramley’s picture

acbramley commented
StatusFileSize
new 2780395-4.patch10.84 KB
new interdiff.txt4.26 KB

Quick update with a simpler normalizer.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review

Let's see if this breaks tests then. :)

Status: Needs review » Needs work

The last submitted patch, 4: 2780395-4.patch, failed testing.

acbramley’s picture

acbramley commented
StatusFileSize
new 2780395-7.patch10.74 KB
new interdiff.txt587 bytes

It will fail because the normalizer calls getUuidRevision which requires the patch from #1812202: Add UUID support for entity revisions however I did find an issue with the namespace in my new test which I've fixed.