Add migration message property to migrate executable

+++ b/core/modules/migrate/src/MigrateExecutable.php
@@ -95,6 +95,13 @@ class MigrateExecutable implements MigrateExecutableInterface {
+  public $message;

Why public? Can we use protected? Or explain why it is public?

Changed a file public function to protected in #3

I'm going to assume this comes back green.

So, an issue summary would have helped... The point is that the public $message is actually being accessed from outside the executable, and this issue is merely trying to document it. The real problem is that the lower-level APIs are trying to talk directly to the front-end via the message interface, which they shouldn't - that should be the executable's job - but, it's not personally a priority to fix that right at this point.

Oh, didn't even notice it failed to apply, I was expecting test errors (which I still expect to see if rerolled to apply).

And, looking at the patches - it seems they're backwards - the real patch is labelled as the interdiff and vice versa.

Thank you neclimdul for correcting error

So let's do this properly keep it public but add a @todo pointing to another issue to make it protected and add an @deprecated saving this is going to be made protected and tell the user which methods on the migrate executable to use.

Patch isn't applying against 8.3.x. Seems also like an novice issue.

$ curl https://www.drupal.org/files/issues/add_migration_message-2778445-6.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   520  100   520    0     0    907      0 --:--:-- --:--:-- --:--:--   907
patching file core/modules/migrate/src/MigrateExecutable.php
Hunk #1 FAILED at 99.
1 out of 1 hunk FAILED -- saving rejects to file core/modules/migrate/src/MigrateExecutable.php.rej

I have re rolled the patch for 8.3.x.
If I can get the issue number mentioned in #17 , I can update the patch with @todo and @deprecated tags.

Uploading patch again as tests are not working

Lets try to review this today.

Rerolled! Now, comments in #17 still apply.

So let's do this properly keep it public but add a @todo pointing to another issue to make it protected and add an @deprecated saving this is going to be made protected and tell the user which methods on the migrate executable to use.

Follow up created in: #2822663: Convert MigrateExecutable::$message to protected property

I`m assuming that @deprecated tag is going to get added by the followup issue. We however didn`t find which method to use instead. @alexpott can you specify?

A.

Right, it makes sense to add the @deprecated when we have the preferred method to point to (in the followup).

This looks good, thanks!

Committed and pushed 4471e30 to 8.3.x and abb08c9 to 8.2.x. Thanks!

diff --git a/core/modules/migrate/src/MigrateExecutable.php b/core/modules/migrate/src/MigrateExecutable.php
index 4fa099b..9c27514 100644
--- a/core/modules/migrate/src/MigrateExecutable.php
+++ b/core/modules/migrate/src/MigrateExecutable.php
@@ -97,7 +97,7 @@ class MigrateExecutable implements MigrateExecutableInterface {
   /**
    * Migration message service.
    *
-   * @todo Make it protected: https://www.drupal.org/node/2822663
+   * @todo https://www.drupal.org/node/2822663 Make this protected.
    *
    * @var \Drupal\migrate\MigrateMessageInterface
    */

Swapping this around to make it more like other @todo's and I just prefer it :)