Follow up to: #2778445: Add migration message property to migrate executable
An public property gets documented, but @mikeryan writes in #9:
The real problem is that the lower-level APIs are trying to talk directly to the front-end via the message interface, which they shouldn't - that should be the executable's job - but, it's not personally a priority to fix that right at this point.
See also comment #17 @alexpott writes:
So let's do this properly keep it public but add a @todo pointing to another issue to make it protected and add an @deprecated saving this is going to be made protected and tell the user which methods on the migrate executable to use.
Comments
Comment #2
mikeryanA quick grep on "executable->message" shows one instance in image/src/Plugin/migrate/process/d6/ImageCacheActions.php, and three instances in migrate/tests/src/Unit/MigrateExecutableMemoryExceededTest.php. Frankly, though, I think ImageCacheActions should use saveMessage() instead of the message service, though (so, like all other messages, it gets saved to the message table).
Once those are fixed, the testbot should reveal anything I missed.
Comment #8
heddnCan't fix this without breaking APIs.