Follow up to: #2778445: Add migration message property to migrate executable

An public property gets documented, but @mikeryan writes in #9:

The real problem is that the lower-level APIs are trying to talk directly to the front-end via the message interface, which they shouldn't - that should be the executable's job - but, it's not personally a priority to fix that right at this point.

See also comment #17 @alexpott writes:

So let's do this properly keep it public but add a @todo pointing to another issue to make it protected and add an @deprecated saving this is going to be made protected and tell the user which methods on the migrate executable to use.

Comments

iMiksu created an issue. See original summary.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

A quick grep on "executable->message" shows one instance in image/src/Plugin/migrate/process/d6/ImageCacheActions.php, and three instances in migrate/tests/src/Unit/MigrateExecutableMemoryExceededTest.php. Frankly, though, I think ImageCacheActions should use saveMessage() instead of the message service, though (so, like all other messages, it gets saved to the message table).

Once those are fixed, the testbot should reveal anything I missed.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Closed (won't fix)

Can't fix this without breaking APIs.