There are calls to entity_load and entity_create methods which are now deprecated in favour of \Drupal::entityTypeManager->getStorage('entity_type')->load() and \Drupal::entityTypeManager->getStorage('entity_type')->create();.

Additionally I have still found a few places where deprecated EntityManager is used.

I attach a patch for this.

CommentFileSizeAuthor
#20 metatag-n2775441-20.patch6.6 KBdamienmckenna
#16 metatag-n2775441-16.interdiff.txt828 bytesdamienmckenna
#16 metatag-n2775441-16.patch7.38 KBdamienmckenna
#14 metatag-n2775441-13.patch7 KBdamienmckenna
#14 metatag-n2775441-13.interdiff.txt571 bytesdamienmckenna
#12 metatag-n2775441-12.interdiff.txt1.32 KBdamienmckenna
#12 metatag-n2775441-12.patch7 KBdamienmckenna
#8 metatag-n2775441-8.png198.93 KBdamienmckenna
#4 metatag-remove_deprecated_entity_function_calls-2775441-4.patch5.67 KBtom_ek
metatag-remove_deprecated_entity_function_calls.patch5.19 KBtom_ek

Comments

tom_ek created an issue. See original summary.

tom_ek’s picture

tom_ek commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, metatag-remove_deprecated_entity_function_calls.patch, failed testing.

tom_ek’s picture

tom_ek commented
StatusFileSize
new metatag-remove_deprecated_entity_function_calls-2775441-4.patch5.67 KB

Fix to pass the tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Lets see if the tests pass.

Status: Needs review » Needs work

The last submitted patch, 4: metatag-remove_deprecated_entity_function_calls-2775441-4.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Needs tests
StatusFileSize
new metatag-n2775441-8.png198.93 KB

skip this, wrong issue

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -Needs tests

Don't need additional tests, and skip the last message, it was on the wrong issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Here's the first error it runs into:

Fatal error: Call to undefined method Drupal\Core\Entity\EntityTypeManager::getBundleInfo() in metatag/src/Form/MetatagDefaultsForm.php on line 120

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2775441-12.patch7 KB
new metatag-n2775441-12.interdiff.txt1.32 KB

WIP.

Status: Needs review » Needs work

The last submitted patch, 12: metatag-n2775441-12.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2775441-13.interdiff.txt571 bytes
new metatag-n2775441-13.patch7 KB

Fixed a typoo.

Status: Needs review » Needs work

The last submitted patch, 14: metatag-n2775441-13.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2775441-16.patch7.38 KB
new metatag-n2775441-16.interdiff.txt828 bytes

"EntityManager has been split into 11 classes": https://www.drupal.org/node/2549139

This should solve the problem.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Replace deprecated entity_load and entity_create with apropriae methods » Replace deprecated entity_load and entity_create with appropriate methods

Status: Needs review » Needs work

The last submitted patch, 16: metatag-n2775441-16.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2741339: Plan for Metatag 8.x-1.0-beta10 release
Related issues: +#2748615: Content metatag default values do not appear in the metatag field

I think the tests are failing because of #2748615: Content metatag default values do not appear in the metatag field.

Lets fix this for the next release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2775441-20.patch6.6 KB

Some of the tests were moved into #2780109: Update all tests so drupalGet() runs before drupalPostForm().

  • DamienMcKenna committed 109750e on 8.x-1.x authored by tom_ek 
    Issue #2775441 by tom_ek, DamienMcKenna: Replace deprecated core entity...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: tom_ek » Unassigned
Status: Needs review » Fixed

Committed. Thanks for bringing this to my attention, tom_ek!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3088848: Drupal 9 release plan for Metatag (ETA: when D9.0.0-beta1 is released)