It's a bit of a hole in the API, I think, that it's currently not possible to get all searches that were cached in the current request – just those of which you know the search ID. We should change that – and add tests for the whole service (I don't think there are any, at the moment).

CommentFileSizeAuthor
#9 2775411-9--results_cache_tests.patch2.58 KBdrunken monkey
#7 2775411-3--results_cache_tests.patch2.5 KBdrunken monkey
#3 2775411-3--results_cache_tests.patch2.5 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +beta blocker
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2775411-3--results_cache_tests.patch2.5 KB

Patch, based on #2772829: Make "search id" a query property instead of option.

Status: Needs review » Needs work

The last submitted patch, 3: 2775411-3--results_cache_tests.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Related issues: +#2775411: Add tests and getAllResults() to the results cache service
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Related issues: -#2775411: Add tests and getAllResults() to the results cache service +#2772829: Make "search id" a query property instead of option
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2775411-3--results_cache_tests.patch2.5 KB

The other issue is finally committed, so re-posting #3.

Status: Needs review » Needs work

The last submitted patch, 7: 2775411-3--results_cache_tests.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2775411-9--results_cache_tests.patch2.58 KB

Re-roll.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This looks great, it has test coverage and the code is very reabable.

  • drunken monkey committed d4e9d7f on 8.x-1.x 
    Issue #2775411 by drunken monkey: Added tests and getAllResults() for...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Excellent, thanks a lot for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.