From #2704061: Sensors ignore thresholds of 0. Drupal 8 testbot's results of the patch at #4, we've found the following bug:
in Drupal\monitoring\Plugin\monitoring\SensorPlugin\CommerceTurnoverSensorPlugin::getEntityQueryAggregate() calling the parent getEntityQueryAggregate() giving 3 params when the parent doesn't need any.
We might also need to fix some configurations as well, since lately (June 19, 2016) there has been a REST configuration change, see #2747231: REST config converted to config entities.
- remove the parameters from the getEntityQueryAggregate() call
- fix the rest monitoring config to config entities where needed (start with demo)
- update IS if necessary (for more accurate info)
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | unneeded_parameters-2775173-6-interdiff.txt | 4.45 KB | berdir |
| #6 | unneeded_parameters-2775173-6.patch | 9.53 KB | berdir |
| #4 | unneeded_parameters-2775173-4.patch | 5.08 KB | tduong |
| #4 | interdiff-2775173-2-4.txt | 2.21 KB | tduong |
Comments
Comment #2
tduong commentedOk, here we go. I still have a bug to fix to make
MultigraphServicesTestto work, it is something about the restful get monitoring-multigraph permission that leads to an "account creation fails" so$this->drupalLogin()cannot login with a NULL user object...Comment #4
tduong commentedFixed some missing/"wrong naming" modules, but there is still something wrong...
Comment #6
berdirThanks for the fixes. Fixed the last failing tests, at least locally.
The search api problem was fixed in the latest dev, that required also a bunch of other changes. We'll have no choice but to wait for a new release there to have the tests green again.
Comment #8
berdirYeah, that's all we can do in monitoring for now.