Sensors ignore thresholds of 0. Drupal 8

This should mention it's a straight port of #2684191: [Needs tests] Sensors ignore thresholds of 0. Anyway, code is fine!

I have added some tests to make sure the exceeds and falls methods use type safe threshold values.

Note that test_only.patch contains only my changes.

Don't worry about the other test fails, I think we have some head test fails there, you can ignore those.

Cool! :) I'm currently working on #2775173: getEntityQueryAggregate() gets unneeded parameters that might fix the failing tests...

In the meantime, just some nitpicks for you:

1. +++ b/src/Tests/MonitoringUITest.php
   @@ -1290,6 +1291,56 @@ class MonitoringUITest extends MonitoringTestBase {
   +   * Tests if the threshold value checks are type safe, especially for zero values.
   

   Too long, should be in max 80 chars. Maybe something like "Tests if thresholds checks are type safe, especially for zero values." (?)

2. +++ b/src/Tests/MonitoringUITest.php
   @@ -1290,6 +1291,56 @@ class MonitoringUITest extends MonitoringTestBase {
   +    $thresholds = array(
   ...
   +    $test_sensor_result_data = array('sensor_value' => 7);
   ...
   +    $thresholds = array(
   ...
   +    $test_sensor_result_data = array('sensor_value' => 7);
   ...
   +    $thresholds = array(
   ...
   +    $test_sensor_result_data = array('sensor_value' => -7);
   ...
   +    $thresholds = array(
   ...
   +    $test_sensor_result_data = array('sensor_value' => -7);
   

   Use the new array syntax where you add them, according to the array std coding ;)

I'm wondering if it's better to extend the existing 4 test methods for these 4 thresholds method check cases instead to have a specific test... If we want to keep this new test method, then maybe we should also add the last two cases (inner/outer intervals) as well .. ?

And please assign this issue to yourself since you are working on it, @alecsmrekar ;)

I think it's not really possible to test the inner and outer intervals as their thresholds can not be set to 0 (fails validation).

Here is the code with arrays reformatted and the code moved back to the existing methods.

And already new test fails :( (still not your problem)

Test looks good, nice work so far. Lets add one more example in each test for a boundary scenario, meaning, when the value is 0 so that we are sure that it works as expected.

Added exceeds and falls test with value 0 and thresholds 0.

Great job! :)
One last thing, can you upload also an interdiff between your patchs please ?

Interdiff attached.

Alright, looks nice :)

Agreed, thanks!