Allowing disable the reset of the h5p user data results when drupal (h5p) node is changed

Thank you, we will try to review this for the next sprint.

This is an old issue but I was running into the same problem. I found that the content_id would always change on node save (regardless of if there were any changes to H5P or not). This would cause the user's data to become out of sync with H5P and thereby "reset" the user's data.

I created a patch which addresses this immediate issue.

It checks to see if the h5p form has changed.

• If it has - Then reset the user's content data as the old data is invalid. (Current Behavior)
• If it hasn't - Then update the content_id of the existing user data so that it is in sync.

Note: This is a relatively fundamental change so this could cause a regression. I also don't like adding the database query directly in H5PEditorWidget. This should be part of H5P Core. However, I understand this may be only appropriate in the context of Drupal. I'll leave it up to the maintainers to determine the best place to put that code.

I should add: this was in the Drupal 8 version of the module.

Updated to include keeping scores when the content id changes. The rationale being that you shouldn't wipe out the results for somebody who has completed the h5p content, even if the quiz changes, authors should have to explicitly state that they want results wiped out. I believe that functionality is available as part of the h5p widget already (see "clear results").

It looks like this issue is for the 7.x branch but we are actually committing patches against 8.x, should we create a new ticket?

I installed patch in #7 (running on a D8 site) and while it does not clear the results - it also does not listen to the reset field settings.

I added a boolean field with a machine name of field_reset_h5p_userdata, but whether the box is checked or not, the results for the quiz are never cleared.

Did I read the comment wrong? Does the patch prevent the resetting of user data UNLESS the author uses the Clear Results option within the h5p content? And therefore I don't need that reset field? Where is the Clear Results option you're referring to? I only see Clear content. (using quiz h5p content type)

Here’s a reroll to make sure the proper translation is loaded for the original entity on D8.

Re-rolled the patch to work with Drupal 9. I also added in a check to see if h5p_save_content_state was enabled. It doesn't make sense to attempt to update user data if we're not capturing it anyway.