One of the result of #2750719: Profile the module for performance bottlenecks was that, even for sites with lots of nodes, about 99% of the search time are actually just spent for highlighting the results. Which is especially insane, since the default view provided by the Defaults module doesn't even show the highlighted data, but just the rendered node.

So, I think it would be a good idea to just disable the highlighting processor in the Defaults module. Any comments to that?

CommentFileSizeAuthor
#3 search_api-disable_highlighting_processor_in_the_defaults_module-2774407-3.patch811 bytesalan-ps
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Assigned: Unassigned » alan-ps

Makes sense for me. I will look at this.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Status: Active » Needs review
FileSize
search_api-disable_highlighting_processor_in_the_defaults_module-2774407-3.patch811 bytes

This is a patch for reviewing. After enabling a module, "highlight" option will be disabled for "Default content index".

Status: Needs review » Needs work

The last submitted patch, 3: search_api-disable_highlighting_processor_in_the_defaults_module-2774407-3.patch, failed testing.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Assigned: alan-ps » Unassigned

The last submitted patch, 3: search_api-disable_highlighting_processor_in_the_defaults_module-2774407-3.patch, failed testing.

drholera’s picture

drholera CreditAttribution: drholera at Adyax commented

Checking.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

The test fails because of #2784849: Tests fail w/ out of memory error..

The last submitted patch, 3: search_api-disable_highlighting_processor_in_the_defaults_module-2774407-3.patch, failed testing.

drholera’s picture

drholera CreditAttribution: drholera at Adyax commented

Yes, I see. This problem related only with core 8.3.x and brakes a lot of issues.

I tested #3 patch locally on fresh drupal 8.3.x core install and patch is correct and works as expected.

mpp’s picture

mpp CreditAttribution: mpp as a volunteer and at AmeXio commented

See https://www.drupal.org/node/2784849#comment-11533091

  • drunken monkey committed 4f7f807 on 8.x-1.x authored by alan-ps 
    Issue #2774407 by alan-ps: Disabled the "Highlighting" processor in the...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs work » Fixed

Looks good, thanks!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.