We only have basefield tests for non-revisonable entities right now. Add basefield tests for revisonable entities with and without data table. This can be backported to 8.x-1.x.

CommentFileSizeAuthor
#31 add_tests_for_base-2773099-31.patch31.66 KBjibran
#31 interdiff.txt1.48 KBjibran
#28 interdiff.txt1.53 KBchx
#28 2773099_28.patch37.94 KBchx
#23 interdiff-8.x-2.x.txt17.73 KBjibran
#23 interdiff-8.x-1.x.txt15.45 KBjibran
#23 add_tests_for_base-2773099-23-8.x-2.x.patch36.3 KBjibran
#23 add_tests_for_base-2773099-23-8.x-1.x.patch33.14 KBjibran
#22 add_tests_for_base-2773099-22.patch18.34 KBjibran
#18 interdiff.txt3.89 KBjibran
#17 add_tests_for_base-2773099-17-8.x-2.x.patch19.82 KBjibran
#6 add_tests_for_base-2773099-6-8.x-2.x.patch16.15 KBjibran
#6 add_tests_for_base-2773099-6-8.x-1.x.patch14.27 KBjibran
#6 interdiff.txt941 bytesjibran
#3 add_tests_for_base-2773099-2-8.x-2.x.patch15.82 KBjibran
#3 add_tests_for_base-2773099-2-8.x-1.x.patch13.93 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 8.x-2.x-dev » 8.x-1.x-dev

Some how this is broken for 8.x-1.x as well.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new add_tests_for_base-2773099-2-8.x-1.x.patch13.93 KB
new add_tests_for_base-2773099-2-8.x-2.x.patch15.82 KB

The last submitted patch, 3: add_tests_for_base-2773099-2-8.x-1.x.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: add_tests_for_base-2773099-2-8.x-2.x.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt941 bytes
new add_tests_for_base-2773099-6-8.x-1.x.patch14.27 KB
new add_tests_for_base-2773099-6-8.x-2.x.patch16.15 KB

It is passing now on 1.x.

The last submitted patch, 6: add_tests_for_base-2773099-6-8.x-1.x.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: add_tests_for_base-2773099-6-8.x-2.x.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Nope it is not passing apparently I was testing the wrong file on PHPStorm.

jibran credited Berdir.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Related issues: +#2506805: Non-revisionable base fields with multiple columns break revisionable entity types

Berdir showed me #2506805: Non-revisionable base fields with multiple columns break revisionable entity types.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review

The last submitted patch, 6: add_tests_for_base-2773099-6-8.x-1.x.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: add_tests_for_base-2773099-6-8.x-2.x.patch, failed testing.

The last submitted patch, 3: add_tests_for_base-2773099-2-8.x-1.x.patch, failed testing.

The last submitted patch, 3: add_tests_for_base-2773099-2-8.x-2.x.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new add_tests_for_base-2773099-17-8.x-2.x.patch19.82 KB

Here are the test fixes for 2.x. This will still fail because of #2775539: DerUpdateTest is failing after 2755525.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff.txt3.89 KB

Status: Needs review » Needs work

The last submitted patch, 17: add_tests_for_base-2773099-17-8.x-2.x.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review

Both patches are ready for review.

Status: Needs review » Needs work

The last submitted patch, 17: add_tests_for_base-2773099-17-8.x-2.x.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new add_tests_for_base-2773099-22.patch18.34 KB

Reroll.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new add_tests_for_base-2773099-23-8.x-1.x.patch33.14 KB
new add_tests_for_base-2773099-23-8.x-2.x.patch36.3 KB
new interdiff-8.x-1.x.txt15.45 KB
new interdiff-8.x-2.x.txt17.73 KB

Added some tests for revsionable entities we can extend those in #2772611: target_id_int column doesn't exist for field revision table.

The last submitted patch, 23: add_tests_for_base-2773099-23-8.x-1.x.patch, failed testing.

The last submitted patch, 23: add_tests_for_base-2773099-23-8.x-1.x.patch, failed testing.

The last submitted patch, 23: add_tests_for_base-2773099-23-8.x-1.x.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 23: add_tests_for_base-2773099-23-8.x-2.x.patch, failed testing.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new 2773099_28.patch37.94 KB
new interdiff.txt1.53 KB

  • chx committed 28023b0 on 8.x-2.x 
    Issue #2773099 by jibran, chx, Berdir: Add tests for base fields of...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
Status: Needs review » Needs work

Thanks for the quick fix.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.48 KB
new add_tests_for_base-2773099-31.patch31.66 KB

  • jibran committed 51a1cbc on 8.x-1.x 
    Issue #2773099 by jibran, chx, Berdir: Add tests for base fields of...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Fixed
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.