Closed (fixed)
Project:
Mailchimp
Version:
8.x-1.x-dev
Component:
General
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Jul 2016 at 10:22 UTC
Updated:
18 Apr 2017 at 22:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
asrobComment #3
amytswan commentedThis would be a good feature to add, @asrob - if you are inspired, please feel free to write a patch and we'll check it out!
Comment #4
asrobOkay, I'll try to write a patch! :)
Comment #5
quironHi guys,
I have the same problem, I writted this patch, for me is working.
Can you try it and give some feedback?
Comment #6
greg boggsThanks Quiron!
Comment #7
f0ns commentedI have the same issue, when I try to translate the signup form on admin/config/services/mailchimp/signup I get a 403 (access denied).
I Tried the patch but it doesn't seem to solve this bug.
I'll try to look into this and investigate it further in the following days.
Comment #8
f0ns commentedIt took me a little longer then expected but here is the patch. Now everything is translatable for the signup form:
Comment #9
f0ns commentedComment #10
f0ns commentedYou can see it in action on my personal website (the block is under the body):
Dutch: https://fonsvandamme.be/blog/drupal-8-contrib-module-readremaining
English: https://fonsvandamme.be/en/blog/drupal-8-contrib-module-readremaining
Comment #11
robin.ingelbrecht commentedThis patch seems to work
Comment #12
f0ns commentedCan this be pushed to the dev branch please?
Comment #13
brtamas commentedI have made the mergvars translatable.
Patch attached.
Comment #14
bsztreha commented#8 worked for me, thanks!
Comment #15
luksak#8 Works for me as well!
Comment #16
luksakAlso test #13 and it works as well. Worth mentioning is that this is not translated using config translation but using string translation. Should we change that?
Comment #17
greg boggsWent ahead with string translation because I don't believe mergevars are Drupal Config.
Comment #19
greg boggsComment #20
greg boggs