Follow-up to #2744197: Proper private file support for images uploaded via EditorImageDialog

Problem/Motivation

Any files uploaded to the private file storage will be treated as external by the "Restrict images to this site" filter. It doesn't matter if the file was uploaded via EditorImageDialog or a standard file field. This problem persists with or without #2744197: Proper private file support for images uploaded via EditorImageDialog, as that issue handles a different problem.

Proposed resolution

Fix the "Restrict images to this site" filter so it treats files uploaded to the private storage as internal.

Remaining tasks

…

User interface changes

None.

API changes

None beyond what's proposed.

Data model changes

None.

CommentFileSizeAuthor
#2 2772617-2.patch1.59 KBthpoul

Comments

Boobaa created an issue. See original summary.

thpoul’s picture

thpoul commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new 2772617-2.patch1.59 KB

This should fix this issue and will treat private image files as local urls. Of course it needs tests.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

thelmer’s picture

thelmer commented

I will work on this issue today, in dublin2016 with mentor @chipway
https://www.drupal.org/contributor-tasks/review

thelmer’s picture

thelmer commented

This issue depends on the changes from #2744197: Proper private file support for images uploaded via EditorImageDialog, and that patch should be applied first.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Handle files uploaded to the private storage as internal » [PP-1] Handle files uploaded to the private storage as internal
Status: Needs review » Postponed

#5: thanks! Updating issue status to reflect that.

boobaa’s picture

boobaa
he/him
commented
Title: [PP-1] Handle files uploaded to the private storage as internal » Handle files uploaded to the private storage as internal
Status: Postponed » Needs review

Parent issue has been fixed.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: editor.module » filter.module

Indeed. But this is not a bug in editor.module.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Closed (duplicate)
Related issues: +#2528214: "Restrict images to this site" blocks image style derivatives

This is a duplicate of #2528214: "Restrict images to this site" blocks image style derivatives.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Please move over relevant parts of the issue/discussion here to that issue!