Is there a way to Skip row processing which matches some condition

In the D7 version of Feeds, you would do this with the "Keyword filter" plugin from Feeds Tamper, but that module hasn't been ported to D8 yet. Not sure how to accomplish the same in the D8 version.

In the D7 version you could also accomplish this by implementing hook_feeds_after_parse() (Feeds Tamper implemented this hook also). Not sure if this hook has been ported to the D8 version of Feeds. Some hooks were converted to events. See feeds/src/Event. If you know how the event system works in D8, perhaps you could make use of that.

1. +++ b/src/Feeds/Item/BaseItem.php
   @@ -8,6 +8,13 @@ namespace Drupal\feeds\Feeds\Item;
   +  protected $process_current_row = TRUE;
   

   This should be camel case.

2. +++ b/src/Feeds/Item/DynamicItem.php
   @@ -31,4 +38,20 @@ class DynamicItem implements ItemInterface {
   +  public function skipRowProcessing($skip) {
   +    if ($skip) {
   +      $this->process_current_row = FALSE;
   +    }
   +    return $this;
   +  }
   

   Why are we returning $this?

- Updated a patch by applying the coding standards recommended from the previous test results.

This use case is going to be implemented with Feeds Tamper. See also #2937721: Create 'SkipException' classes..

It could perhaps be useful though to make skipping rows easier without Tamper. Attached is a patch for that idea.
Basically you would extend the AfterParseBase class, implement alterItem() and throw a \Drupal\feeds\Exception\SkipItemException when the item to import should be skipped.

Hi,
Can someone review and mark this as RTBC if it is fine? We need to do some validations before the excel is accepted for upload. I believe the latest patch should allow us to achieve that. Or is there some other module in D8 which allows to add custom validations for the fields uploaded via feeds?

Using patch #12 on our live project. Works as expected.

@artematem
Thanks for trying! I'm using this patch also with success on a few sites, but it would be useful to have an automated test for this feature.

Now with a unit test. Also fixes some coding standard issues.

Single coding standard fix.

Committed #18.

Hello, I managed to use SkipItemException for my dataset, but since I need to assign my data to different categories using Tamper's Find/Replace I end up unable to match the source data I want to skip. As far as I understand, this is because Tamper also works with FeedEvents::PARSE stage. Is there a way to access the source info instead of the tampered one?

@tbatzakas
Yes, you can change the order in which event subscribers are called. Both Feeds Tamper and the AfterParseBase class have set the same priority, which is FeedsEvents::AFTER. This constant equals -10000, see feeds/src/Event/FeedsEvents:

/**
 * After plugin executes priority.
 */
const AFTER = -10000;

For event subscribers, subscribers with a higher value are called first. So to have your subscriber called first before Feeds Tamper's one, you could simply increase the value with one: FeedsEvents::AFTER + 1.

Override the static method getSubscribedEvents() in your custom subscriber class to change the priority:

use Drupal\feeds\Event\FeedsEvents;

/**
 * {@inheritdoc}
 */
public static function getSubscribedEvents() {
  $events = [];
  $events[FeedsEvents::PARSE][] = ['afterParse', FeedsEvents::AFTER + 1];
  return $events;
}

Can someone share their implementation of #12?

@MegaChriz?
@artematem?
@tbatzakas?

I found this to be enough to get me where I needed to go: https://www.drupal.org/project/feeds/issues/3128379

I'm happy to provide a code example if someone needs it.