Remove deprecated use of db_select https://api.drupal.org/api/drupal/core!includes!database.inc/function/db... and db_delete https://api.drupal.org/api/drupal/core!includes!database.inc/function/db...

CommentFileSizeAuthor
#8 patch_2772089.diff4.6 KBlpsolit
#7 patch_2772089.diff2.61 KBlpsolit
#3 remove_deprecated_usage-2772089-3.patch2.72 KBborisson_
#3 interdiff.txt536 bytesborisson_
#2 db-select-delete_2772089.patch2.74 KBjalpesh

Comments

jalpesh created an issue. See original summary.

jalpesh’s picture

jalpesh commented
Assigned: jalpesh » Unassigned
Status: Active » Needs review
StatusFileSize
new db-select-delete_2772089.patch2.74 KB

Here we go with patch.Thanks.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff.txt536 bytes
new remove_deprecated_usage-2772089-3.patch2.72 KB

I fixed one small thing to comply with the drupal coding standards. It's not allowed to use a FQN in code. RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: remove_deprecated_usage-2772089-3.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

Back to rtbc, the fail on php5.5 is unrelated.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

Thanks for the patch.

I prefer \Drupal:.database() over Database::getConnection().

And for the plugin class, lets properly inject the database connection, replacing with the static call doesn't bring us anything.

lpsolit’s picture

lpsolit commented
Assigned: Unassigned » lpsolit
Status: Needs work » Needs review
StatusFileSize
new patch_2772089.diff2.61 KB

Not sure what you mean by "for the plugin class, lets properly inject the database connection", so I simply replaced db_select() by \Drupal::database()->select() there too. Tell me what you meant exactly if you want me to change it.

lpsolit’s picture

lpsolit commented
StatusFileSize
new patch_2772089.diff4.6 KB

OK, I think I got it. :)

  • Berdir committed f6611af on 8.x-1.x authored by LpSolit 
    Issue #2772089 by LpSolit, borisson_, jalpesh: Remove deprecated usage...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Yeah, exactly like that, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.