Currently in admin side, description column of listing tables have vertical-align : middle property in default admin theme seven, which makes a complex look if the table td content is a little more than just one line. I was confused on the description content in module listing page. Description content went above the module name. So I thought that the description belongs to the previous Module. Had to look twice to realise that it was aligned in the middle (See the screenshot below).

Current Listing

So, I think it we can just remove vertical-align property. It will make the listing more easy to read and understand (see the proposed change screenshot).

Proposed Listig

CommentFileSizeAuthor
#11 after-applying-patch.png49.58 KBAkshay kashyap
#11 before-applying-patch.png50.02 KBAkshay kashyap
#5 drupal-verticalalign-2771975-0.patch282 bytesJoel James
proposed.png18.18 KBJoel James
current.png22.29 KBJoel James
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joeljames created an issue. See original summary.

Joel James’s picture

Joel James CreditAttribution: Joel James commented
Issue summary: View changes
Joel James’s picture

Joel James CreditAttribution: Joel James commented
Title: Remove vertical-align from listing tables for better UX » Change vertical-align in listing tables description column for better UX
Issue summary: View changes
Joel James’s picture

Joel James CreditAttribution: Joel James commented
Title: Change vertical-align in listing tables description column for better UX » Remove vertical-align in listing tables description column for better UX
Issue summary: View changes
Issue tags: +seven-theme
Joel James’s picture

Joel James CreditAttribution: Joel James commented
FileSize
drupal-verticalalign-2771975-0.patch282 bytes
Joel James’s picture

Joel James CreditAttribution: Joel James commented
Status: Active » Needs review
Joel James’s picture

Joel James CreditAttribution: Joel James commented
Assigned: Joel James » Unassigned
Joel James’s picture

Joel James CreditAttribution: Joel James as a volunteer commented
chanchal2002’s picture

chanchal2002 CreditAttribution: chanchal2002 as a volunteer and at Sidus Technologies commented
Issue tags: +CSS

Yes, I think we can remove vertical-align property.

For drupal 8 vertical-align property not included .

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 at Material commented

I have applied the patch, drupal-verticalalign-2771975-0.patch mentioned in #5.
It's removed the vertical alignment in listing tables description.

Hence, the patch is working fine.

Akshay kashyap’s picture

Akshay kashyap CreditAttribution: Akshay kashyap commented
FileSize
before-applying-patch.png50.02 KB
after-applying-patch.png49.58 KB

Patch is working fine, i just test the patch #5.
Step for applying patch
1) Download Drupal version 7.44 X.
2) Check the issue (before-applying-patch.png).
3) Apply patch (after-applying-patch.png).
4) Issue tested on the Mozila and Chrome.
5) Issue resolved.

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 at Material commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Status: Reviewed & tested by the community » Needs review

This definitely looks like a good change on the Modules page.

I'm not entirely convinced we want to do this for all tables, though. At least not without further review and testing... that's a very broad change that could have unintended consequences.

Also for the Modules page the issue isn't limited to the Seven theme. A similar problem exists in other themes also. So another way to do this would be to do it outside the Seven theme, and have the CSS target the specific table on the Modules page only (by setting it to vertical-align: baseline)?

Joel James’s picture

Joel James CreditAttribution: Joel James as a volunteer commented

@David

Yes, vertical-align: baseline is the best approach. Thanks.

I think we can target the modules table alone by using its parent fieldset id. But where shall we write this outside a theme, to affect on all themes?