[serial] Serial Field

Howdy
Thanks, help is greatly appreciated. Just back from a few weeks off, I will continue the work + keep you posted about the progress.

Thanks for the feedback. Some coding standards sounds unclear to me, I tend to follow PSR-2 but PHP const are still uppercase in the Drupal CS. Anyway, I propose to use Coder once done.

I took some time documenting on this issue, without finding a better way, so I will still continue on the current naming convention.
Any thoughts on this ?

Had some time to go on today and ended up on a first working version, still non atomic yet.
Main issues left

• Handle atomicity
• Update the existing entities instances
• Rename a bundle
• Coding standards
• Unit testing

They should be closed before the end of September, right in time ; )

@colan I will take some time to update what I missed from the 7.x issue tracker + let you know.

@matsbla thanks for testing, I can reproduce this and after a quick check I see 3 possibly related issues here, I will look into this

1. The Manage display form (e.g. admin/structure/types/manage/article/display) throws "Drupal\Component\Plugin\Exception\PluginException: The plugin (integer) did not specify an instance class. in Drupal\Component\Plugin\Factory\DefaultFactory::getPluginClass() (line 79 of /var/www/drupal82/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php)." Issue on github Fixed
2. Pathauto and visibility : Pathauto aliases will not work if Serial field is hidden, to be verified in D8.
3. Todo left in the SerialItem class. Currently, dependending on the content translation configuration you follow (create serial field then install Content translation module), you have to uncheck translation for the serial field in admin/config/regional/content-language (or e.g. admin/structure/types/manage/article/fields/node.article.field_serial) which is probably unfair because in most use cases, the serial id should follow the entity translation concept where node id's are the same, unlike i18n in D7 (see related issue Sync Serial Field with translated nodes). Issue on github

@matsbla

1. 1. I have already opened a question for this on github https://github.com/r-daneelolivaw/serial/issues/9, so I think we agree. It is designed as is in D7, but if we do not conflict with other cases / issues (e.g. #2383301: Make serial IDs optional, #2742255: "Field XY is required" error when creating new node) I suggest we open a new issue for this when the 8.x branch is available on DO.
2. 2. This is the way token exposes values for integer (see example for a plain int field), no idea if we can override this, indeed would be more site builder friendly. @all any feedback?

@colan the module has been ported with this issue patch #2455677: Getting Duplicate numbers and gaps in the sequence order included (#9) + I just did a manual check from the latest codebase

@matsbla the pathauto issue with content translation installed should be fixed now.

It seems that the expected behavior of serial amongst entity translations is the same serial id (see #888850: Sync Serial Field with translated nodes + comment #11 3.) which is currently the case in the module port: the site builder decides that he wants a new serial for each translation via "Users may translate this field" option, but is it clear enough?

Both options for defining field translation are available
- field level (e.g. admin/structure/types/manage/article/fields/node.article.field_serial)
- global content language and translation level (admin/config/regional/content-language)
these are the default ones for field translation, so should be ok.

+1 for creating separated issues about non blocking things, one topic at a time.

Some remaining issues are about code polishing, the blockers are still

• Implement field create and delete instance operations
• Rename a bundle
• Coding standards

I'm on it and will keep you posted.

Howdy,

We are not so far from a release, the main remaining issues were fixed, leaving coding standards, Node clone support and a bit of refactoring.

A bit stuck with bundle renaming: is it still available under Drupal 8?
I cannot find traces from hook_field_attach_rename_bundle, hook_entity_bundle_rename anymore and the UI does not seem to expose bundle renaming.
If we look at the Drupal\Core\Entity\Entity class, the setOriginalId method specifies :

By default, entities do not support renames and do not have original IDs.

I cannot find traces of rename in the subclasses of Entity either and the entity.api.php mentions

These machine names are considered permanent, they may not be renamed.

Am I missing something or can we consider that we can get rid of bundle renaming?

Ok thanks, I removed that feature from the SerialStorageInterface.
I can work a bit later this week on the unit test but do not think that the remaining issues are blocking + the coding standards have been applied.

Thanks, merged

I will recreate the GitHub issues on DO.

Updated the issue summary for clarity (replaced the GitHub references by the Drupal.org ones), as described by @mmjvb we should now review remaining issues and decide with the module maintainers when a first alpha release is available then identify what are beta blockers.
I have no time to work on this project before February 2018, but will definitely be happy to help on remaining issues then.

@Cyberflyer all good, imo the first issue that we should work on is #2833506: Prevent regression of closed issues, so other contributors can run automated tests while producing patches. I can start with that in February.

Added a patch for #2868303: Type not found for custom Entity and created a first port of the unit tests to PHPUnit #2833506: Prevent regression of closed issues.

I propose to continue with #2862447: Serial field not populated when node created programmatically + if we consider this feature as a mvp #2847954: Allow having starting value for the serial field and set existing entities initialization as optional, we need to take this into account #2945658: Add an option to bypass default serial initialization for existing entities.

+ probably a few updates from the 7.x branch that should be forward ported, any feedback?

Cross-posting #3020133: Offering to maintain Serial Field 8.x

Thank you @colan! I will start the work on the RTBC's this week

Merged / closed a bunch of issues these last 2 weeks, thanks a lot to all the persons that helped on these ones :)

Did some extensive testing today and we are (finally) close to a release.
Opened 2 new issues, 1 of them needs review:

• #3058900: Initialize values on existing entities for other entity types than Node
• #3058891: Do not return a default value if the serial id has not not been initialized on existing entities

Then the following issues will be updated from the latest codebase during the dev days, next week

• Default migration support / test
• #2857566: Help Text
• #2833506: Prevent regression of closed issues

We have a first alpha release https://www.drupal.org/project/serial/releases/8.x-1.0-alpha1