When I wrote the patch for #2763505: Move file_entity and file_browser's Field Widget for Files and Images to Entity Browser, I didn't realize that #limit_validation_errors works as a whitelist of form elements to validate, and would remove form state if left empty. As a result, if you click "Remove" right now when using the FileBrowserWidget, it wipes form state (essentially removing all elements).
What I really wanted was to ignore validation errors if the Remove button was clicked, which this patch should do. The flagErrors() logic is copied from core's FileWidget class.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2767373_2.patch | 1.09 KB | slashrsm |
| #2 | interdiff.txt | 1.32 KB | slashrsm |
| entity-browser-file-widget-remove-fix.patch | 1.58 KB | samuel.mortenson |
Comments
Comment #2
slashrsm commentedWhat about this solution? This will only validate target_id, since it is needed by the remove button. That might work as it will prevent alt, title, description, ... form being validated.
There is errorElement() on parent class which seems to be trying to achieve something similar. I think that it would make sense to solve this in there if possible.
Comment #3
samuel.mortensonNice, this is working well from my manual testing with File Browser. Thanks @slashrm!
Comment #4
slashrsm commentedGreat! Committed.