Comments

jibran created an issue. See original summary.

chx’s picture

Status: Active » Needs review
StatusFileSize
new2.55 KB
chx’s picture

StatusFileSize
new2.98 KB
larowlan’s picture

Some suggested minor changes - thanks for coming back to this - appreciate it?

  1. +++ b/dynamic_entity_reference.install
    @@ -11,6 +11,23 @@ use Drupal\Core\Entity\Sql\SqlEntityStorageInterface;
    + * This is an incredible mess because
    

    incredible mess » immensely complicated

  2. +++ b/dynamic_entity_reference.install
    @@ -11,6 +11,23 @@ use Drupal\Core\Entity\Sql\SqlEntityStorageInterface;
    + * \Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema::saveFieldSchemaData(0
    

    0 » ) ?

  3. +++ b/dynamic_entity_reference.install
    @@ -11,6 +11,23 @@ use Drupal\Core\Entity\Sql\SqlEntityStorageInterface;
    + * is protected so the field storage schema need to be saved into the key-value
    

    need » needs

  4. +++ b/dynamic_entity_reference.install
    @@ -11,6 +11,23 @@ use Drupal\Core\Entity\Sql\SqlEntityStorageInterface;
    + * yet another key-value storage which also needs to manually kept up-to-date.
    

    needs to » needs to be

  5. +++ b/src/EventSubscriber/FieldStorageSubscriber.php
    @@ -69,6 +69,13 @@ class FieldStorageSubscriber implements EventSubscriberInterface {
    +    // When enabling a module implementing providing an entity type,
    

    implementing or providing but not both?

jibran’s picture

StatusFileSize
new4.72 KB
new5.38 KB

Fixed #4 and some other stuff.

chx’s picture

Very quick review during boarding:

+ * This is an immensely complicated because

minus an

- * Returns an appropriate plpgsql function name.
+ * Returns an appropriate pgsql function name.

plpgsql. That's a word and that's correct. https://www.postgresql.org/docs/8.3/static/plpgsql.html

jibran’s picture

StatusFileSize
new1.08 KB
new4.89 KB

Here we go.

chx’s picture

Status: Needs review » Reviewed & tested by the community

Let's do this, I guess.

  • jibran committed 5c26a8e on 8.x-2.x authored by chx
    Issue #2766195 by jibran, chx: Improve documentation of non-numeric...
jibran’s picture

Status: Reviewed & tested by the community » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.