I tried to run this patch (#80) to solve several different problems in my Drupal 8.1.6 site but it seems to have been failed (please see the attached image).

I was asked in the comments to publish the problem I encountered in a different thread and thus I do.

CommentFileSizeAuthor
Failqm.JPG62.22 KBBenia

Comments

Benia created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented

You should apply patches from the root of your Drupal directly. Also you should use patch -p1 < the.patch

Benia’s picture

Benia commented

Oh, wasn't it that in D7 we needed to use the diff path (the path that appears in the diff) ?

cilefen’s picture

cilefen commented
Priority: Critical » Normal

Support requests are not critical.

Benia’s picture

Benia commented
Priority: Normal » Critical

I thought it should be marked as Critical given its based on an issue that was defined as such.

cilefen’s picture

cilefen commented
Priority: Critical » Normal

@Benia Support requests are not critical. All Drupal core patches are made with respect to the Drupal core directory, just as @catch wrote in #2. You are in the wrong directory. The command is:

patch -p1 < 2595535-80.patch

This patch applies cleanly to 8.1.6.

Benia’s picture

Benia commented

Okay I ran that and it now seems to work fine. But please guys, do you think that the fact I ran it in the wrong directory is dangerous and I should now expect problems because of that?

(/var/www/html/benia/core/modules/config_translation/src/Access instead of the core directory off course)

Thanks !!!

cilefen’s picture

cilefen commented
Status: Needs work » Fixed

No. `patch` could not find any files to patch.

You, like everyone, should use source control to understand changes to your files. Then you would not have to worry.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.